Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The results of a diagonal throw depends on which diagonal it is #17025

Open
yyzsong opened this issue Feb 2, 2025 · 2 comments
Open

The results of a diagonal throw depends on which diagonal it is #17025

yyzsong opened this issue Feb 2, 2025 · 2 comments
Labels
Bug Incorrect functionality.

Comments

@yyzsong
Copy link
Contributor

yyzsong commented Feb 2, 2025

Description

See title. If a warrior diagonally lunges along a wall at a marine to her southwest, she will successfully grab him. (See fig. 1) If the same warrior lunges to the northeast, the grab attempt will fail. (See fig. 2)

This also applies to thrown items, by the way.

Test Merges

Don't remember, but it shouldn't matter.

Reproduction Steps

It's hard to describe verbally, try recreating the images.

Screenshots

Fig. 1
Image
Fig. 2
Image

@yyzsong yyzsong added the Bug Incorrect functionality. label Feb 2, 2025
@yyzsong yyzsong changed the title The results of a diagonal throw depend on which diagonal it is The results of a diagonal throw depends on which diagonal it is Feb 2, 2025
@antropod
Copy link
Contributor

I will take a look

@antropod
Copy link
Contributor

After some debugging, I added visualization for the steps the item makes when thrown, here are the results:

Image Image

so when you throw item, it moves in cardinal steps, starting with x direction and if there is a wall it stops, here is the bug.

I guess I could work on changing how throw_at works (Do I need a green light from maintainers?).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Incorrect functionality.
Projects
None yet
Development

No branches or pull requests

2 participants