Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request] Update shading when filtering by category #7

Open
ejektaflex opened this issue Nov 26, 2022 · 1 comment
Open

[Feature Request] Update shading when filtering by category #7

ejektaflex opened this issue Nov 26, 2022 · 1 comment

Comments

@ejektaflex
Copy link

Hi, I really like your site! However, I wanted to be able to visualize where player homes get placed and while I could filter by player home, it didn't seem to update the heatmap when I added the filter. Is that something that could be added?

User story: I wanted to add some nice player homes at regular intervals throughout the map to support a non-fast-travel playthrough, and this site helps a lot but it would be a lot easier if the heatmap reflected the current results after filtering by category.

@thallada
Copy link
Owner

Thanks for the suggestion.

When you click on a cell and see the list of mods in the sidebar, that list of mods is constrained to only mods that have edited that cell. So, if the heatmap were to be dynamic to show edits based on that list of mods, and you, for example, filtered the list to Player homes mods, the heatmap would only show edits on the map for Player homes mods that have at least one edit in the selected cell. It sounds like that's not exactly what you want. It sounds like you'd rather have a list of ALL mods that have edited any cell and then have the ability to filter to Player homes in that list and see the heatmap update to edits from that filtered list.

A filterable list of ALL mods doesn't currently exist in the UI (only list of mods per cell and per plugin), so I think that would be a prerequisite to implementing this feature. My main concern with implementing a list like that is that a list of all mods with all of the data needed to display, filter, and update the heatmap would be massive. The frontend doesn't directly make any requests to the mod database, everything is pre-generated to static JSON files every night. This includes the data for the heatmap. It is computed from every mod in the database. This takes a while and would definitely not be possible to do on the fly when users visit the site.

I could constrain it quite a bit by only including mods that edit at least one cell, but I still think it might be too big. I'll need to try generating that and see how big it is to see if it would be too prohibitively big.

There's an alternative solution that I think could solve the specific use-case here. In addition to generating a list of cell edits for all mods, I could generate one for each category of mods. Then, on the main sidebar I could add a category dropdown which would filter the heatmap down to only edits for mods in that category. I don't think it would be a stretch to also have the ability to filter down by edition and translations as well. However, I don't think it would be possible to include a text input filter. It sounds like that should be sufficient to get what you want?

Separately, I have also gotten a similar suggestion that the heatmap should update to reflect all of the changes in your load order once you load the plugins in your Data folder. Essentially a personal heatmap for your load order. All of the data to do this is already readily available in the browser, so I don't think it would be too hard to also add a toggle that switches the heatmap to show only edits from plugins in the loaded/added plugins.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants