Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Init 2.0 skeleton (starting from db service) + 9armbot console #47

Merged
merged 12 commits into from
Apr 20, 2021

Conversation

narze
Copy link
Collaborator

@narze narze commented Apr 1, 2021

Overview

Initiate v2.0.0 skeleton with well-separated classes services

Motivation & Context (Why?)

#44 & #46

Proposed Changes

  • Init project skeleton
  • Add database service

Implementation Details (How?)

  • Add TypeScript 🏆
  • Introduce 9armbot-2.0 folder, which will be separated from the existing 9armbot completely.
  • Add basic features to db service, with unit tests.
  • Add npm run dev-2.0 & npm run test-2.0
  • Add 9armbot console! npm run console

Usage / QA

  • npm run dev-2.0
  • (wip) I'll try to add REPL to control db from CLI, for ease of testing
    • Done :
      image

Concerns

เนื่องจากเป็นการเปลี่ยนจาก JavaScript เป็น TypeScript อาจทำให้เกิด barrier ขึ้นได้
ถ้ารู้สืกว่าแก้โค้ดแล้วรันไม่ผ่านสักที อาจพิจารณาลดความโหดของ TS compiler ได้จาก settings เหล่านี้ (tsconfig.json)

image

@narze narze changed the base branch from main to v2.0.0 April 1, 2021 06:03
@narze narze marked this pull request as draft April 1, 2021 06:21
@narze narze marked this pull request as ready for review April 1, 2021 17:21
@narze
Copy link
Collaborator Author

narze commented Apr 1, 2021

ผมทำไว้เท่านี้ก่อน เดี๋ยวเยอะเกินละรีวิวยาก 🙏

@narze narze changed the title feat: init 2.0 skeleton, starting from db service Init 2.0 skeleton (starting from db service) + 9armbot console Apr 1, 2021
@thananon thananon merged commit 2772e77 into thananon:v2.0.0 Apr 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants