-
Notifications
You must be signed in to change notification settings - Fork 57
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add bench-fast make target which excludes long-running benchmarks #292
Comments
hi @fpetkovski I would like to work on this issue to start being familiar with the project |
Feel free to start on it 👍 |
Hey @fpetkovski , I've been trying to understand the codebase. Can you please assign me this issue so I can work on this ? |
Please see above comment. |
@fpetkovski would you give the pr a look? |
/assign |
Just notice that they are currently commented out; but having the target doesnt hurt i suppose! |
During local development I often rely on the benchmarks to know whether changes I make are going in the right direction.
We currently have some very slow ones so I usually comment those out, but that creates issues when switching branches and I sometimes even commit the commented out code to my branch.
It would be nice to have a
bench-fast
make target that only runs six hour dataset benchmarks so that we can get faster feedback.The text was updated successfully, but these errors were encountered: