Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Protections and SetMembershipPolicyRevisionIssuerare not being informed of MembershipChanges in some situations #718

Open
Gnuxie opened this issue Feb 2, 2025 · 2 comments
Open

Protections and SetMembershipPolicyRevisionIssuerare not being informed of MembershipChanges in some situations #718

Gnuxie opened this issue Feb 2, 2025 · 2 comments
Labels
2.0.0 Follow Up Issue discoverd in after the release of Draupnir 2.0.0 L3 Some Users Likelihood P3 Outrageous / Cannot continue to or start to use Priority level - includes missing documentation leading to same outrage etc T6 Crash Bug causes crash OR data loss

Comments

@Gnuxie
Copy link
Member

Gnuxie commented Feb 2, 2025

I don't know how this bug is caused, but it's almost like the revision issuer is completely cutoff.

In the Draupnir where this was observed we had the following:

  1. Room protected by draupnir, says so in !draupnir rooms list
  2. spam bot joins
  3. spam bot isn't detected by either MemberBanSynchronisationProtection or RedactionSynchronisationProtection
  4. reprotecting the room (by using rooms remove, then rooms add) causes MemberBanSynchronisationProtection to trigger and ban the user, but not RedactionSynchronisationProtection. Which implies that RedactionSynrhronisationProtection cannot see the membership change.

This could mean either:

  1. The room is omitted from sync
  2. The handles for the protections aren't being called
  3. The SetRoomMembershipRevisionIssuer is not being issued properly
  4. Either the RoomStateRevisionIssuer or RoomMembershipRevisionIssuer's are not issuing revisions properly.
@Gnuxie Gnuxie added 2.0.0 Follow Up Issue discoverd in after the release of Draupnir 2.0.0 L3 Some Users Likelihood P3 Outrageous / Cannot continue to or start to use Priority level - includes missing documentation leading to same outrage etc T6 Crash Bug causes crash OR data loss labels Feb 2, 2025
@Gnuxie
Copy link
Member Author

Gnuxie commented Feb 3, 2025

To aid debugging this, if we don't think this is some weird knock on effect of the backing store breaking. We could add something to the rooms list command that shows how recently the revisions were created.

@Gnuxie
Copy link
Member Author

Gnuxie commented Feb 6, 2025 •
edited
Loading

We could also add a !draupnir rooms state event <room> <state type> <key> command to also help debug this. alongside #716

Gnuxie added a commit to Gnuxie/matrix-protection-suite that referenced this issue Feb 10, 2025
@Gnuxie
Forgot to export revisionID on interface of StateRevision.
7da7b0b 
the-draupnir-project/Draupnir#718.
Gnuxie added a commit that referenced this issue Feb 10, 2025
@Gnuxie
Show when rooms were last updated in the rooms list command.
e9e163e 
#718.
@Gnuxie Gnuxie mentioned this issue Feb 10, 2025
Merged
Gnuxie added a commit that referenced this issue Feb 10, 2025
@Gnuxie
Merge pull request #725 from the-draupnir-project/gnuxie/revision-fee…
94f41d7 
…dback

Show the time of the last `RoomStateRevision` for each room in the `!draupnir rooms` command. 

We also do this for policy lists.

#718
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
2.0.0 Follow Up Issue discoverd in after the release of Draupnir 2.0.0 L3 Some Users Likelihood P3 Outrageous / Cannot continue to or start to use Priority level - includes missing documentation leading to same outrage etc T6 Crash Bug causes crash OR data loss
Projects
Draupnir planning
Status: No status
Milestone
No milestone
Development

No branches or pull requests
1 participant
@Gnuxie