From ee2954495192b82708f3799af18ce6104698fea3 Mon Sep 17 00:00:00 2001 From: George Pattichis Date: Mon, 23 Dec 2024 00:07:42 +0200 Subject: [PATCH 1/3] Fix deprecated warning --- changelog/fix-TEC-5086_deprecated_notice | 4 ++++ src/Tribe/PUE/Checker.php | 2 ++ 2 files changed, 6 insertions(+) create mode 100644 changelog/fix-TEC-5086_deprecated_notice diff --git a/changelog/fix-TEC-5086_deprecated_notice b/changelog/fix-TEC-5086_deprecated_notice new file mode 100644 index 0000000000..aba867a0a1 --- /dev/null +++ b/changelog/fix-TEC-5086_deprecated_notice @@ -0,0 +1,4 @@ +Significance: patch +Type: fix + +Resolve warning about deprecation of passing null to version_compare function. diff --git a/src/Tribe/PUE/Checker.php b/src/Tribe/PUE/Checker.php index 486bd87c53..5ffb583b68 100755 --- a/src/Tribe/PUE/Checker.php +++ b/src/Tribe/PUE/Checker.php @@ -1641,6 +1641,8 @@ public function get_installed_version() { $all_plugins = get_plugins(); if ( array_key_exists( $this->get_plugin_file(), $all_plugins ) && array_key_exists( 'Version', $all_plugins[ $this->get_plugin_file() ] ) ) { return $all_plugins[ $this->get_plugin_file() ]['Version']; + } else { + return ''; } } } From 7c494f09692711dbd95aecd4b0af333e83101f94 Mon Sep 17 00:00:00 2001 From: George Pattichis Date: Tue, 7 Jan 2025 01:24:20 +0200 Subject: [PATCH 2/3] WP version (6.4.1) does not meet minreq for TEC. Plugin requires WP 6.5. --- .github/workflows/tests-php-eva.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/tests-php-eva.yml b/.github/workflows/tests-php-eva.yml index 5c4cd2d917..095bf6eba1 100644 --- a/.github/workflows/tests-php-eva.yml +++ b/.github/workflows/tests-php-eva.yml @@ -355,7 +355,7 @@ jobs: run: | ${SLIC_BIN} up wordpress ${SLIC_BIN} wp core version - ${SLIC_BIN} wp core update --force --version=6.4.1 + ${SLIC_BIN} wp core update --force --version=6.5 ${SLIC_BIN} wp core version - name: Run suite tests if: steps.skip.outputs.value != 1 From a721a6234d204787ca144e15ed0fb5be8ec9c8fb Mon Sep 17 00:00:00 2001 From: George Pattichis Date: Tue, 7 Jan 2025 01:36:48 +0200 Subject: [PATCH 3/3] WP version (6.4.1) does not meet minreq for TEC. Plugin requires WP 6.5. --- .github/workflows/tests-php.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/tests-php.yml b/.github/workflows/tests-php.yml index 465829b4ae..7bb7359a31 100644 --- a/.github/workflows/tests-php.yml +++ b/.github/workflows/tests-php.yml @@ -178,7 +178,7 @@ jobs: run: | ${SLIC_BIN} up wordpress ${SLIC_BIN} wp core version - ${SLIC_BIN} wp core update --force --version=6.4.1 + ${SLIC_BIN} wp core update --force --version=6.5 ${SLIC_BIN} wp core version - name: Run suite tests if: steps.skip.outputs.value != 1