Skip to content
This repository has been archived by the owner on Sep 30, 2021. It is now read-only.

db.use_ssl should be set to true #65

Open
pieterlukasse opened this issue May 28, 2019 · 3 comments
Open

db.use_ssl should be set to true #65

pieterlukasse opened this issue May 28, 2019 · 3 comments

Comments

@pieterlukasse
Copy link
Contributor

pieterlukasse commented May 28, 2019

Would be good to have db.use_ssl=true in our portal.properties. See https://github.com/thehyve/cbioportal-docker/blob/master/portal.properties#L14

@pieterlukasse
Copy link
Contributor Author

Or at least comment why it is hard to get it working with ssl (which I don't expect). Looks like an extra property would be needed: https://github.com/cBioPortal/cbioportal/blob/master/core/src/main/java/org/mskcc/cbio/portal/util/DatabaseProperties.java#L61

@fedde-s
Copy link
Member

fedde-s commented May 29, 2019

Wouldn't the database need a valid SSL certificate for its hostname to do that? It seems to me that that only really becomes an issue if it's listening on an external (public) host, rather than on a container hostname that's only accessible from within the Docker-managed virtual network.

@pieterlukasse
Copy link
Contributor Author

Maybe this issue is a better place to start: cBioPortal/cbioportal#6180

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants