Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Could not resolve "@floating-ui/dom" #77

Closed
mruknowme opened this issue Nov 12, 2024 · 4 comments
Closed

Could not resolve "@floating-ui/dom" #77

mruknowme opened this issue Nov 12, 2024 · 4 comments
Labels
bug Something isn't working enhancement New feature or request

Comments

@mruknowme
Copy link
Contributor

With nx setup getting this error during build

[ERROR] Could not resolve "@floating-ui/dom"
      
          node_modules/flowbite-angular/fesm2022/flowbite-angular-dropdown.mjs:9:65:
            9 │ ...osition, offset, flip, shift, autoUpdate } from '@floating-ui/dom';
@MGREMY
Copy link
Collaborator

MGREMY commented Nov 14, 2024

That's why we have to get rid of @floating-ui

Add this into your package.json
"@floating-ui/dom": "1.2.6",

@mruknowme
Copy link
Contributor Author

Yes, added for now, hopefully it's temporary.

@MGREMY
Copy link
Collaborator

MGREMY commented Nov 14, 2024

It's temporary, this library need to go out since we can achieve the same result with TailwindCSS classes

@MGREMY MGREMY added bug Something isn't working enhancement New feature or request labels Nov 14, 2024
@MGREMY MGREMY mentioned this issue Nov 23, 2024
Closed
@bence444 bence444 mentioned this issue Dec 3, 2024
Merged
11 tasks
MGREMY added a commit that referenced this issue Dec 11, 2024
@MGREMY
feat/fix(dropdown): use tailwind classes instead of @floating-ui/dom …
0f3a2a3 
…#77 #83 (#86)

## PR Checklist

Please check if your PR fulfills the following requirements:

<!--- [ ] Tests for the changes have been added (for bug
fixes/features)-->

- [ ] Docs have been added/updated (for bug fixes/features)

## PR Type

What kind of change does this PR introduce?

<!-- Please check the one that applies to this PR using "x". -->

- [x] Bugfix
- [x] Feature
- [ ] Code style update (formatting, local variables)
- [ ] Refactoring (no functional changes, no API changes)
- [ ] Build related changes
- [ ] CI-related changes
- [ ] Documentation content changes
- [x] Other... Please describe:

## Issue Number

<!-- Bugs and features must be linked to an issue. -->

Issue Number: #77 #83 

## Does this PR introduce a breaking change?

<!-- If this PR contains a breaking change, please describe the impact
and migration path for existing applications below. -->

- [ ] Yes
- [x] No

## Other information

<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->
## Summary by CodeRabbit

- **New Features**
- Enhanced dropdown component styling and positioning for improved
layout and visibility.

- **Bug Fixes**
- Streamlined dropdown component functionality by removing outdated
lifecycle hooks and methods.

<!-- end of auto-generated comment: release notes by coderabbit.ai -->
@MGREMY
Copy link
Collaborator

MGREMY commented Dec 11, 2024 •
edited
Loading

Closing this issue since in the 1.1.0, @floating-ui is not a dependency anymore
Also, you can remove ur from your package.json :)

@MGREMY MGREMY closed this as completed Dec 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@mruknowme @MGREMY