Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Feature] ScrollTop - Customize icon #85

Closed
MGREMY opened this issue Nov 23, 2024 · 0 comments · Fixed by #96
Closed

[Feature] ScrollTop - Customize icon #85

MGREMY opened this issue Nov 23, 2024 · 0 comments · Fixed by #96
Assignees
@MGREMY
Labels
enhancement New feature or request good first issue Good for newcomers
Milestone
1.4.0

Comments

@MGREMY
Copy link
Collaborator

MGREMY commented Nov 23, 2024 •
edited
Loading

Description

We need to add a way to customize the icon displayed inside the ScrollTop component

Proposed solution

Define an input icon as a model<TemplateRef<unknown> | undefined>(undefined). (See if undefined works or put null instead)

Alternatives considered

No response
@MGREMY MGREMY added enhancement New feature or request good first issue Good for newcomers labels Nov 23, 2024
@MGREMY MGREMY self-assigned this Nov 23, 2024
@MGREMY MGREMY added this to the 1.2.0 milestone Dec 16, 2024
@MGREMY MGREMY linked a pull request Dec 16, 2024 that will close this issue
feat(scroll-top): add support for icon customisation #96
Merged
11 tasks
@MGREMY MGREMY mentioned this issue Dec 16, 2024
Merged
11 tasks
@MGREMY MGREMY moved this from Ready to In progress in Flowbite Angular Library Dec 16, 2024
@MGREMY MGREMY moved this from In progress to In review in Flowbite Angular Library Dec 16, 2024
MGREMY added a commit that referenced this issue Dec 16, 2024
@MGREMY
feat(scroll-top): add support for icon customisation (#96)
fe25ed8 
## PR Checklist

Please check if your PR fulfills the following requirements:

<!--- [ ] Tests for the changes have been added (for bug
fixes/features)-->

- [ ] Docs have been added/updated (for bug fixes/features)

## PR Type

What kind of change does this PR introduce?

<!-- Please check the one that applies to this PR using "x". -->

- [ ] Bugfix
- [x] Feature
- [ ] Code style update (formatting, local variables)
- [ ] Refactoring (no functional changes, no API changes)
- [ ] Build related changes
- [ ] CI-related changes
- [ ] Documentation content changes
- [ ] Other... Please describe:

## Issue Number

<!-- Bugs and features must be linked to an issue. -->

Issue Number: #85 

## Does this PR introduce a breaking change?

<!-- If this PR contains a breaking change, please describe the impact
and migration path for existing applications below. -->

- [ ] Yes
- [x] No

## Other information

<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->
## Summary by CodeRabbit

- **New Features**
	- Added support for dynamic icons in the scroll-to-top feature.

- **Bug Fixes**
- Ensured that existing functionality and layout remain unaffected by
the new component integration.
<!-- end of auto-generated comment: release notes by coderabbit.ai -->
@github-project-automation github-project-automation bot moved this from In review to Done in Flowbite Angular Library Dec 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@MGREMY MGREMY

Labels
enhancement New feature or request good first issue Good for newcomers
Projects
Flowbite Angular Library
Archived in project
Milestone
1.4.0
Development

Successfully merging a pull request may close this issue.

feat(scroll-top): add support for icon customisation themesberg/flowbite-angular
1 participant
@MGREMY