[Feature] {Accordion} - Possibility to change icon #95
Comments
11 tasks
11 tasks
MGREMY
added a commit
that referenced
this issue
Dec 16, 2024
## PR Checklist Please check if your PR fulfills the following requirements: <!--- [ ] Tests for the changes have been added (for bug fixes/features)--> - [x] Docs have been added/updated (for bug fixes/features) ## PR Type What kind of change does this PR introduce? <!-- Please check the one that applies to this PR using "x". --> - [ ] Bugfix - [x] Feature - [ ] Code style update (formatting, local variables) - [ ] Refactoring (no functional changes, no API changes) - [ ] Build related changes - [ ] CI-related changes - [ ] Documentation content changes - [ ] Other... Please describe: ## Issue Number <!-- Bugs and features must be linked to an issue. --> Issue Number: #95 ## Does this PR introduce a breaking change? <!-- If this PR contains a breaking change, please describe the impact and migration path for existing applications below. --> - [ ] Yes - [x] No ## Other information <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit - **New Features** - Added a demo section for the new accordion component in the documentation. - **Documentation** - Updated documentation to include a new "Arrow style" section with code snippets for the accordion component. <!-- end of auto-generated comment: release notes by coderabbit.ai -->
github-project-automation
bot
moved this from In review
to Done
in Flowbite Angular Library
20 tasks
MGREMY
added a commit
that referenced
this issue
Dec 31, 2024
## PR Checklist Please check if your PR fulfills the following requirements: <!--- [ ] Tests for the changes have been added (for bug fixes/features)--> - [x] Docs have been added/updated (for bug fixes/features) ## PR Type What kind of change does this PR introduce? <!-- Please check the one that applies to this PR using "x". --> - [ ] Bugfix - [x] Feature - [ ] Code style update (formatting, local variables) - [ ] Refactoring (no functional changes, no API changes) - [ ] Build related changes - [ ] CI-related changes - [x] Documentation content changes - [ ] Other... Please describe: ## Issue Number <!-- Bugs and features must be linked to an issue. --> Issue Number: N/A ## Does this PR introduce a breaking change? <!-- If this PR contains a breaking change, please describe the impact and migration path for existing applications below. --> - [ ] Yes - [x] No ## Other information Remaining works to do: - [x] fix icons in first/last and prev/next button - [x] possibility to use custom icons, like in accordion (#95) - [ ] ~~possibility to customize buttons' label + internalization~~ - [x] implement different size variables - [x] remove duplications from `libs/flowbite-angular/core/flowbite.theme.init.ts` - [x] remove unused pageChange output - [x] create InjectionTokens for properties (tabs, pageSize, etc..) - [x] use a cleaner way to customize `PaginationButtonDirective` (big thanks @MGREMY ) - [x] requested changes <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit ## Summary by CodeRabbit ## Release Notes: Flowbite Angular Pagination Component - **New Features** - Introduced multiple Pagination components with various configurations, including default, custom, and text navigation modes. - Added support for customizable pagination styles and attributes such as current page, total items, and page size. - Expanded the available SVG icons for navigation. - **Documentation** - Updated documentation with comprehensive examples for different pagination styles and configurations. - Added compatibility information for library versions with Angular and TailwindCSS. - **Improvements** - Enhanced theming capabilities for pagination components. - Improved error handling for page navigation controls. <!-- end of auto-generated comment: release notes by coderabbit.ai -->
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Description
Make possible to change the accordion icon when open/close state
Proposed solution
Make a model input of type
TemplateRef<unknown>Insert it if not undefined, otherwise insert default icon
Alternatives considered
No response
The text was updated successfully, but these errors were encountered: