From 460acf6419ebe1b0aa8432d3a90c879f825a1466 Mon Sep 17 00:00:00 2001 From: "Md.Harun-Ur-Rashid" Date: Tue, 18 Jul 2023 10:59:15 +0600 Subject: [PATCH 1/2] Get text field default value from helper --- views/options/field-types/text.php | 8 +++----- 1 file changed, 3 insertions(+), 5 deletions(-) diff --git a/views/options/field-types/text.php b/views/options/field-types/text.php index 026c19a31..132111054 100644 --- a/views/options/field-types/text.php +++ b/views/options/field-types/text.php @@ -9,11 +9,9 @@ * @since 2.0.0 */ -$value = $this->get( $field['key'] ); -if ( empty( $value ) && isset( $field['default'] ) ) { - $value = $field['default']; -} -$field_key = isset( $field['key'] ) ? esc_attr( $field['key'] ) : null; +$field_key = sanitize_key( $field['key'] ); +$default = isset( $field['default'] ) ? $field['default'] : false; +$value = $this->get( $field_key, $default ); $field_id = esc_attr( 'field_' . $field_key ); $placeholder = isset( $field['placeholder'] ) ? esc_attr( $field['placeholder'] ) : esc_attr( $field['desc'] ); $field_classes = isset( $field['field_classes'] ) ? $field['field_classes'] : ''; From 15b30ef4635d2836a5d56faca0d498e2535866ea Mon Sep 17 00:00:00 2001 From: "Md.Harun-Ur-Rashid" Date: Tue, 18 Jul 2023 10:59:45 +0600 Subject: [PATCH 2/2] Textarea field default value from helper --- views/options/field-types/textarea.php | 9 +++------ 1 file changed, 3 insertions(+), 6 deletions(-) diff --git a/views/options/field-types/textarea.php b/views/options/field-types/textarea.php index 39df4520d..68ec1601e 100644 --- a/views/options/field-types/textarea.php +++ b/views/options/field-types/textarea.php @@ -9,12 +9,9 @@ * @since 2.0.0 */ -$field_key = sanitize_key( $field['key'] ); -$value = $this->get( $field_key ); -if ( empty( $value ) && isset( $field['default'] ) ) { - $value = $field['default']; -} - +$field_key = sanitize_key( $field['key'] ); +$default = isset( $field['default'] ) ? $field['default'] : false; +$value = $this->get( $field_key, $default ); $field_id = sanitize_key( 'field_' . $field_key ); $placeholder = isset( $field['placeholder'] ) ? $field['placeholder'] : $field['desc']; $max_length = isset( $field['maxlength'] ) ? (int) $field['maxlength'] : 0;