Support different shells #18
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bodhi
approved these changes
Feb 19, 2024
idealhack
reviewed
Feb 19, 2024
Don't fail if the shell is not recognized, just use the export command keeping the previous behavior.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As a fish shell user, I've found that our project currently only supports the bash style (
export X=Y) of setting environment variables when I use the-envoption. The purpose of this PR is to support other common shells.How to determine which type of shell to use for exporting commands that set environment variables?
-shelloption to specify the shell type you want explicitly.-shellis not provided, then use the current user's default shell type, which is we can read from the SHELL environment variable.I don't think you'll need provide the
-shelloption in most cases, unless you're manually entering a shell different from the default, which is rare, and this is the only reason the-shelloption exist.Any thoughts? @theplant/sre @bodhi Thank you! :)