Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove everything between %( and ). #42

Open
svengt opened this issue Dec 12, 2018 · 3 comments
Open

Remove everything between %( and ). #42

svengt opened this issue Dec 12, 2018 · 3 comments
Assignees
Labels

Comments

@svengt
Copy link

svengt commented Dec 12, 2018

Should't this line be text = re.sub('\%\(.*?\)s?', '', text) https://github.com/Thermondo/pytest-translations/blob/master/pytest_translations/po_spelling.py#L82, or something in that direction?

We're getting spelling failures on words like ss. This happens when you have two format variables right next to each other. For example: 'this is a %(test1)s%(test2)s'.

@codingjoe
Copy link
Contributor

Hi @svengt!
Thanks for reaching out. We actually don't use the library that much anymore, we switched to msgcheck. That being said, I would be delighted if you can provide a patch to resolve the issue.
We also did some similar improvements on msgcheck, especially when it comes to parsing. Maybe they can serve as reference to work on a patch.
Best
-Joe

@svengt
Copy link
Author

svengt commented Dec 13, 2018

@codingjoe Thank you for your quick reply. I was not aware of the package msgcheck, thanks for pointing that out. We will try that first, see if it fits our needs. 👍

@codingjoe
Copy link
Contributor

codingjoe commented Dec 14, 2018

👌

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants