Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make is hard to cancel, if you do it interactively #14

Open
weitzj opened this issue Nov 8, 2017 · 0 comments
Open

make is hard to cancel, if you do it interactively #14

weitzj opened this issue Nov 8, 2017 · 0 comments

Comments

@weitzj
Copy link

weitzj commented Nov 8, 2017

Right now make build runs Docker without interactive mode and launches a live-server.
One cannot cancel the live-server using CTRL+C, since Docker does not have the -it flag set.

Therefore it would be good to, either:

  • add -it flag, i.e. docker run -it -v pwd:/srv/gitbook -v pwd/_book:/srv/html bketelsen/gitbook

or:

Create a separate interactive build-target for the Makefile

Issue Type

About the Dockerfile

Language

global

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant