Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Default value for nb_np_list parameter. #18

Open
thilinarmtb opened this issue Sep 23, 2017 · 2 comments
Open

Default value for nb_np_list parameter. #18

thilinarmtb opened this issue Sep 23, 2017 · 2 comments
Assignees

Comments

@thilinarmtb
Copy link
Owner

PR #15 set the default value of nb_np_list to 1 if the user did not provide any.
One problem I see with that is the given case may not run with a single MPI rank.
May be a better way to do this may be to set a nb_np_list value depending on
the machine. We can move the definition of the variable to appropriate machine
file and set it accordingly. For example, for linux machine type this can be 4,
for cetus, this can be 64.

@kent0 : What do you think?

@kent0
Copy link
Collaborator

kent0 commented Sep 23, 2017

It's true that the default value of 1 won't work if a specific machine has more than 1 core. In that case the user will have to specify the value/s anyway. It may be a good idea for it to be machine specific, but I think it's ok for the 'default' to be 1. We may want to use a model where default values get set in go.sh, but gets overridden by sourcing a machine specific variables file. We can also follow this model and add a user configuration file that will get sourced before the tests start.

@thilinarmtb
Copy link
Owner Author

Yes, this is exactly what I am talking about. Let's keep this issue till we add machine
specific defaults. Currently, the defaults are for a linux machine type.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants