Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

php 7.3 support #98

Open
marchesesimone opened this issue Jun 22, 2020 · 1 comment
Open

php 7.3 support #98

marchesesimone opened this issue Jun 22, 2020 · 1 comment

Comments

@marchesesimone
Copy link

marchesesimone commented Jun 22, 2020

hello I report that some dependencies of the library are not compatible with php 7.3.
Below are the errors found:

`FILE: sites/all/libraries/mailchimp/vendor/phpunit/phpunit-mock-objects/tests/_fixture/SingletonClass.php

FOUND 1 ERROR AFFECTING 1 LINE
17 | ERROR | Visibility for magic method __sleep must be public. Found: private
| | (PHPCompatibility.FunctionDeclarations.NonStaticMagicMethods.__sleepMethodVisibility)

FILE: /sites/all/libraries/mailchimp/vendor/sebastian/diff/tests/ParserTest.php

FOUND 3 ERRORS AFFECTING 3 LINES
83 | ERROR | The body of a heredoc/nowdoc can not contain the heredoc/nowdoc closing marker as text at the start of a line since PHP 7.3.
| | (PHPCompatibility.Syntax.NewFlexibleHeredocNowdoc.ClosingMarkerNoNewLine)
126 | ERROR | The body of a heredoc/nowdoc can not contain the heredoc/nowdoc closing marker as text at the start of a line since PHP 7.3.
| | (PHPCompatibility.Syntax.NewFlexibleHeredocNowdoc.ClosingMarkerNoNewLine)
134 | ERROR | The body of a heredoc/nowdoc can not contain the heredoc/nowdoc closing marker as text at the start of a line since PHP 7.3.
| | (PHPCompatibility.Syntax.NewFlexibleHeredocNowdoc.ClosingMarkerNoNewLine)

Time: 13 mins, 31.46 secs; Memory: 204.01MB
`

@mariacha
Copy link
Contributor

Since those errors are in items pulled into the vendor folder, this is only relevant if you're running unit tests on the api itself. For phpunit/phpunit-mock-objects the project is archived, so probably the next step is to find a replacement generally. For sebastian/diff that's a test that would only be run during unit testing for that package, not for mailchimp. Unless I'm missing something, this seems like it's not blocking any of the functionality of the Mailchimp API module itself, so the fix feels pretty low priority.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants