Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor DTO layer to support v1 flag format only #2403

Open
3 tasks done
thomaspoignant opened this issue Sep 20, 2024 · 0 comments · May be fixed by #2496
Open
3 tasks done

Refactor DTO layer to support v1 flag format only #2403

thomaspoignant opened this issue Sep 20, 2024 · 0 comments · May be fixed by #2496
Assignees
@thomaspoignant
Labels
📍 Assigned change This is a change in the code that should not affect the users p2 Medium priority 📌 Pinned stop v0 support Tag to group everything about the un-support of v0.x.x flag format

Comments

@thomaspoignant
Copy link
Owner

thomaspoignant commented Sep 20, 2024 •
edited
Loading

Warning

As mention in the issue #2398 we have decided to drop the support of the v0.x.x flag format.
Before creating a pull request for that, please check in the main issue if is the right moment to do it.

In order to remove support of v0 format we should ensure that the DTO is not accepting the old format anymore.

What should we do?

  • Remove DTOv0 from the main DTO
  • Remove the v0 converter and any code calling it.
  • Refactor the DTO the DTOv1 fields directly in the DTO
@thomaspoignant thomaspoignant added p2 Medium priority change This is a change in the code that should not affect the users stop v0 support Tag to group everything about the un-support of v0.x.x flag format labels Sep 20, 2024
@thomaspoignant thomaspoignant mentioned this issue Sep 20, 2024
Open
@thomaspoignant thomaspoignant linked a pull request Oct 10, 2024 that will close this issue
Open
2 tasks
@thomaspoignant thomaspoignant self-assigned this Oct 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@thomaspoignant thomaspoignant

Labels
📍 Assigned change This is a change in the code that should not affect the users p2 Medium priority 📌 Pinned stop v0 support Tag to group everything about the un-support of v0.x.x flag format
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

chore: Remove support for v0 format thomaspoignant/go-feature-flag
1 participant
@thomaspoignant