Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(bug) Tracing only initializes when specifying endpoint through config #2578

Closed
hairyhenderson opened this issue Oct 26, 2024 · 4 comments · Fixed by #2579
Closed

(bug) Tracing only initializes when specifying endpoint through config #2578

hairyhenderson opened this issue Oct 26, 2024 · 4 comments · Fixed by #2579
Assignees
Labels
bug Something isn't working p1 High priority

Comments

@hairyhenderson
Copy link
Contributor

Observed behaviour

After #2482 and #2485, tracing won't initialize unless the openTelemetryOtlpEndpoint config entry is set. When I'm using OTEL_EXPORTER_OTLP_ENDPOINT instead I'd rather not have to specify it in the configuration as well.

Expected Behavior

Tracing should be disabled via OTEL_SDK_DISABLED=true, otherwise it should be enabled by default.

Steps to reproduce

No response

@hairyhenderson hairyhenderson added bug Something isn't working needs-triage A priority should be added to the issue labels Oct 26, 2024
@hairyhenderson
Copy link
Contributor Author

/assign-me

Copy link
Contributor

👋 Hey @hairyhenderson, this issue is already assigned to @thomaspoignant.

⚠️ It will become unassigned if it isn't closed within 10 days.

🔧 A maintainer can also add you to the list of assignees or swap you with the current assignee.

@hairyhenderson
Copy link
Contributor Author

Well I tried - either way I'm going to take this on, it's a simple fix 😉

@thomaspoignant thomaspoignant added p1 High priority and removed needs-triage A priority should be added to the issue labels Oct 26, 2024
@hairyhenderson
Copy link
Contributor Author

#2579 should solve this 🙂

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working p1 High priority
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants