Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Performance improvement by removing WaitUntilReady from individual operation #14

Closed
Amar-C opened this issue Sep 3, 2024 · 10 comments
Closed
Assignees

Comments

@Amar-C
Copy link
Collaborator

Amar-C commented Sep 3, 2024

Hi,

Looks like WaitUntilReady is called from individual operations. Do we need to call it before every operation? Can we just call it during initial connection setup? If we remove this from individual operation, we can gain ~15% more performance from this plugin (internal testing results)

@thotasrinath thotasrinath self-assigned this Sep 4, 2024
@thotasrinath
Copy link
Owner

Thanks for the findings @Amar-C, I will make it optional.

@sharathjag
Copy link
Collaborator

Hi @thotasrinath
I work with @Amar-C and can contribute towards this issue. Do you have few minutes to discuss how you want us to proceed? Let me know what time/timezone works for you.

@thotasrinath
Copy link
Owner

Hi @sharathjag, I am comfortable with SG timezone. Let me know when you would like to connect.

@sharathjag
Copy link
Collaborator

Thanks @thotasrinath I will send an invite your way. Is there a way to reach out to you?

Also opened: #17
Happy to discuss that as well when we sync.

@thotasrinath
Copy link
Owner

Thanks, I can connect through teams. Please send me an invite on [email protected]

@Amar-C
Copy link
Collaborator Author

Amar-C commented Oct 23, 2024

@thotasrinath As the PR is merged can you help create a new release for it?

@thotasrinath
Copy link
Owner

Sure @Amar-C, Can help to update readme according to the changes please.

@Amar-C
Copy link
Collaborator Author

Amar-C commented Oct 24, 2024

Sure @Amar-C, Can help to update readme according to the changes please.

Yup, Sharath updated the README. Could you please create a new tag? I can do it but not sure which CPU are you building the binary for?

@thotasrinath
Copy link
Owner

thotasrinath commented Oct 24, 2024 via email

@Amar-C
Copy link
Collaborator Author

Amar-C commented Oct 30, 2024

https://github.com/thotasrinath/xk6-couchbase/releases/tag/v0.0.9 should have the improvements

@Amar-C Amar-C closed this as completed Oct 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants