Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrating to sql-alchemy 2.0 - Better typing support in the ORM #2769

Open
1 task
Tracked by #479
VannTen opened this issue Jan 30, 2023 · 3 comments
Open
1 task
Tracked by #479

Migrating to sql-alchemy 2.0 - Better typing support in the ORM #2769

VannTen opened this issue Jan 30, 2023 · 3 comments
Labels
kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. kind/feature Categorizes issue or PR as related to a new feature. priority/backlog Higher priority than priority/awaiting-more-evidence. sig/stack-guidance Categorizes an issue or PR as relevant to SIG Stack Guidance.

Comments

@VannTen
Copy link
Member

VannTen commented Jan 30, 2023 •
edited
Loading

Problem statement

Better typing is better code

High-level Goals

In so many words, fully typed ORM support (see 2.0 Features

Additional context

We also in storages (see graph/ in particular ) a lot of code which replicates sql-alchemy methods. This is the occasion to get rid of those.

Acceptance Criteria

  • Full migration to sqlalchemy 2.0 in storages and the of users of storages.
@VannTen VannTen added the kind/feature Categorizes issue or PR as related to a new feature. label Jan 30, 2023
@VannTen VannTen mentioned this issue Jan 30, 2023
Open
3 tasks
@KPostOffice
Copy link
Member

Migration guide

@codificat
Copy link
Member

/sig stack-guidance
/kind cleanup

@sesheta sesheta added sig/stack-guidance Categorizes an issue or PR as relevant to SIG Stack Guidance. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. labels Jan 31, 2023
@github-project-automation github-project-automation bot moved this to 🆕 New in Planning Board Jan 31, 2023
@Gkrumbach07
Copy link
Member

Add graph-ql support too? Possible library we could use

@goern goern moved this from 🆕 New to 📋 Backlog in Planning Board Feb 7, 2023
@goern goern added the priority/backlog Higher priority than priority/awaiting-more-evidence. label Feb 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. kind/feature Categorizes issue or PR as related to a new feature. priority/backlog Higher priority than priority/awaiting-more-evidence. sig/stack-guidance Categorizes an issue or PR as relevant to SIG Stack Guidance.
Projects
Planning Board
Status: 📋 Backlog
Milestone
No milestone
Development

No branches or pull requests
6 participants
@goern @codificat @Gkrumbach07 @VannTen @KPostOffice @sesheta