Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support thoth image builds via github actions #193

Open
1 task
erikerlandson opened this issue Feb 10, 2022 · 6 comments
Open
1 task

Support thoth image builds via github actions #193

erikerlandson opened this issue Feb 10, 2022 · 6 comments
Assignees
Labels
kind/feature Categorizes issue or PR as related to a new feature. priority/backlog Higher priority than priority/awaiting-more-evidence. sig/user-experience Issues or PRs related to the User Experience of our Services, Tools, and Libraries. triage/accepted Indicates an issue or PR is ready to be actively worked on.

Comments

@erikerlandson
Copy link

erikerlandson commented Feb 10, 2022

Is your feature request related to a problem? Please describe.
Developers on github are often familiar with using github actions, but are generally not familiar with more bespoke systems like thoth, aicoe-ci, etc.
cc @negillett @MichaelClifford @caldeirav @goern

User story:
As a maintainer of some github repo(s) that I would like built via thoth s2i, I am familiar with working with github actions, and I would like to be able to configure these builds to be managed via github actions, as an alternative to configuring a thoth yaml, installing thoth bots, and submitting specialized image-build issue forms. Having this managed via github actions allows me a single place to configure the building, and it allows me to control which gh events trigger the actions, which branches they are enabled, for, etc. It saves the log output of all builds via standard gh links which are persisted, so I (1) always know where to look for my build logs, and (2) I know these logs are saved.

High-level Goals

  1. Implement a github action that can do thoth image builds.

Describe the solution you'd like
See above

References relating to customized github actions
Using custom images for actions
https://docs.github.com/en/actions/using-workflows/workflow-syntax-for-github-actions#jobsjob_idcontainer
Hosting your own runner
https://docs.github.com/en/actions/hosting-your-own-runners

Describe alternatives you've considered
The alternative is to educate new community members on how thoth, sesheta, aicoe-ci, etc, work.
This is also a credible solution, but is more work than hypothetically saying "here use this github action..."

Acceptance Criteria

  • Create a custom github action that can be used to do thoth builds
@erikerlandson erikerlandson added the kind/feature Categorizes issue or PR as related to a new feature. label Feb 10, 2022
@sesheta sesheta added the needs-triage Indicates an issue or PR lacks a `triage/...` label and requires one. label Feb 10, 2022
@Gkrumbach07
Copy link
Member

Other benefits of having a GitHub action for Thoth image build:

  • Less steps to integrate Thoth image builder. Instead if using yaml files and bots, a repo owner can simply add a preset GitHub action.
  • An already integrated way to see past build logs and build fails. As a repo owner, you have better clarity of the history and current state of the image builds.
  • External users are more likely to be familiar with the standards of a GitHub workflow file, giving them more flexibility to customize when the image build runs. i.e. GitHub workflow triggers.

@erikerlandson
Copy link
Author

An already integrated way to see past build logs and build fails. As a repo owner, you have better clarity of the history and current state of the image builds.

this would also be an excellent solution for thoth-station/core#316

github's infra provides a standard link to the output of all its workflow steps, and they are also saved for future reference

@Gregory-Pereira
Copy link
Member

/assign

@codificat
Copy link
Member

/triage accepted
/priority important-soon
/sig user-experience

@sesheta sesheta added triage/accepted Indicates an issue or PR is ready to be actively worked on. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. sig/user-experience Issues or PRs related to the User Experience of our Services, Tools, and Libraries. and removed needs-triage Indicates an issue or PR lacks a `triage/...` label and requires one. labels Mar 25, 2022
@sesheta
Copy link
Member

sesheta commented Jun 23, 2022

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

/lifecycle stale

@sesheta sesheta added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jun 23, 2022
@harshad16
Copy link
Member

/remove-lifecycle stale

@sesheta sesheta removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jul 14, 2022
@codificat codificat moved this to 📋 Backlog in Planning Board Sep 24, 2022
@goern goern added priority/backlog Higher priority than priority/awaiting-more-evidence. and removed priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. labels Feb 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature Categorizes issue or PR as related to a new feature. priority/backlog Higher priority than priority/awaiting-more-evidence. sig/user-experience Issues or PRs related to the User Experience of our Services, Tools, and Libraries. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
Status: 📋 Backlog
Development

No branches or pull requests

7 participants