Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Advise results: which are more useful than the other #259

Open
TomasTomecek opened this issue Jul 19, 2022 · 4 comments
Open

Advise results: which are more useful than the other #259

TomasTomecek opened this issue Jul 19, 2022 · 4 comments
Labels
kind/feature Categorizes issue or PR as related to a new feature. priority/backlog Higher priority than priority/awaiting-more-evidence. sig/user-experience Issues or PRs related to the User Experience of our Services, Tools, and Libraries. triage/accepted Indicates an issue or PR is ready to be actively worked on.

Comments

@TomasTomecek
Copy link

Is your feature request related to a problem? Please describe.

Just going through the latest results in my console for https://thoth-station.ninja/search/adviser-220719131518-f9cde332e97c5073/summary and giving you feedback for the output. I separate every point with a <hr>. Let's go!

Multiple imports for...

There are too many lines on the output, I have no control over the code inside our dependencies.


No version range specifier...

Could be a single line with multiple dependencies, doesn't need to be a single line for every dep. I also understand this is important for people that install directly from PyPI.


A lot of the INFO lines could even be suppressed: No $tool used


Runtime environment used is no longer supported, it is recommended to switch to another runtime environment

Please write which environment, I don't understand what I should change.


No CPU model provided...

I don't care about this and specifically don't have control over CPU in our CI.


Skipping including package ('urllib3', '1.25.5', 'https://pypi.org/simple') as a CVE 'PYSEC-2020-149' was found

I don't understand if there is anything I should change or if Thoth is just telling me that it doesn't take that CVE into account.


Stack report: I like the table in the Web UI with ❌ and ✅: that's easy to read. In the console, there is a lot of text that's hard to parse. Could there e.g. be some score number that would tell the healthiness? So that in console it would only be a single line per project.


That's it! Overall the web interface is easier to read for me, especially the stack report. I also appreciate the Compare tab so that I can see what has changed in the meantime. One thing I'd highlight is that it's hard for me to find any of the points actionable - it's good that I know that information but it's not in my control do anything about it. Examples of actionable items:

  • "Dependency $XYZ has low health project status and can be replaced with $ASD"

  • "You are using setup.py style of Python packaging. Please consider migrating to $QWE"

  • "Option $A in setup.cfg is deprecated, please use $B"

@TomasTomecek TomasTomecek added the kind/feature Categorizes issue or PR as related to a new feature. label Jul 19, 2022
@sesheta
Copy link
Member

sesheta commented Jul 19, 2022

@TomasTomecek: This issue is currently awaiting triage.
One of the @thoth-station/devs will take care of the issue, and will accept the issue by applying the
triage/accepted label and provide further guidance.

The triage/accepted label can be added by org members by writing /triage accepted in a comment.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@sesheta sesheta added needs-triage Indicates an issue or PR lacks a `triage/...` label and requires one. needs-sig labels Jul 19, 2022
@goern
Copy link
Member

goern commented Jul 20, 2022

/sig user-experience
/priority important-soon

@sesheta sesheta added sig/user-experience Issues or PRs related to the User Experience of our Services, Tools, and Libraries. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. and removed needs-sig labels Jul 20, 2022
@goern
Copy link
Member

goern commented Aug 11, 2022

might be related to thoth-station/core#417

@Gkrumbach07 Gkrumbach07 added triage/accepted Indicates an issue or PR is ready to be actively worked on. and removed needs-triage Indicates an issue or PR lacks a `triage/...` label and requires one. labels Sep 6, 2022
@Gkrumbach07
Copy link
Member

will be fixed by the completion of this epic thoth-station/core#417

@codificat codificat moved this to 📋 Backlog in Planning Board Sep 24, 2022
@goern goern added priority/backlog Higher priority than priority/awaiting-more-evidence. and removed priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. labels Feb 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature Categorizes issue or PR as related to a new feature. priority/backlog Higher priority than priority/awaiting-more-evidence. sig/user-experience Issues or PRs related to the User Experience of our Services, Tools, and Libraries. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
Status: 📋 Backlog
Development

No branches or pull requests

4 participants