Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add an ability to manage lock files in nested directories #464

Closed
fridex opened this issue Jul 1, 2020 · 5 comments
Closed

Add an ability to manage lock files in nested directories #464

fridex opened this issue Jul 1, 2020 · 5 comments
Labels
kind/feature Categorizes issue or PR as related to a new feature.

Comments

@fridex
Copy link
Contributor

fridex commented Jul 1, 2020

Is your feature request related to a problem? Please describe.

Some projects maintain lock files not in a git root directory, but in some of the nested dirs present in the repo. This structure makes it harder to integrate with Thoth.

Describe the solution you'd like

Add an ability to maintain lock files in nested directories. The configuration file .thoth.yaml will be picked from one of the parent directories.

Describe alternatives you've considered

Copy .thoth.yaml file into nested directories so that the configuration is picked along with the lock file.

@fridex
Copy link
Contributor Author

fridex commented Jul 1, 2020

Low priority as of now.

@pacospace
Copy link
Contributor

@pacospace
Copy link
Contributor

Is your feature request related to a problem? Please describe.

Some projects maintain lock files not in a git root directory, but in some of the nested dirs present in the repo. This structure makes it harder to integrate with Thoth.

Describe the solution you'd like

Add an ability to maintain lock files in nested directories. The configuration file .thoth.yaml will be picked from one of the parent directories.

Describe alternatives you've considered

Copy .thoth.yaml file into nested directories so that the configuration is picked along with the lock file.

What if different steps in a pipeline requires use of different hardware (just to mention one degree of freedom for the selection of the software stack)? each software stack should be coupled with a specific .thoth.yaml. See links above.

@fridex
Copy link
Contributor Author

fridex commented Nov 3, 2020

Is your feature request related to a problem? Please describe.
Some projects maintain lock files not in a git root directory, but in some of the nested dirs present in the repo. This structure makes it harder to integrate with Thoth.
Describe the solution you'd like
Add an ability to maintain lock files in nested directories. The configuration file .thoth.yaml will be picked from one of the parent directories.
Describe alternatives you've considered
Copy .thoth.yaml file into nested directories so that the configuration is picked along with the lock file.

What if different steps in a pipeline requires use of different hardware (just to mention one degree of freedom for the selection of the software stack)? each software stack should be coupled with a specific .thoth.yaml. See links above.

Adviser's input require direct dependencies, runtime environment and other vectors being constant. The resolved stack is specific to the input vector provided.

@sesheta sesheta added kind/feature Categorizes issue or PR as related to a new feature. and removed enhancement labels Jan 28, 2021
@fridex
Copy link
Contributor Author

fridex commented Feb 23, 2021

This can be closed as we introduced overlays. The overlay approach taken can manage multiple lock files for different runtime environments. See overlays configuration option.

@fridex fridex closed this as completed Feb 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature Categorizes issue or PR as related to a new feature.
Projects
None yet
Development

No branches or pull requests

3 participants