Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AttributeError: 'formatConfigDetails' is set to 'currencyFormatConfig', not 'numberFormatConfig' #170

Closed
3 tasks done
jmmizerany opened this issue Sep 12, 2024 · 5 comments
Labels
bug Something isn't working

Comments

@jmmizerany
Copy link
Contributor

First Stop

  • I have read and agreed to the ThoughtSpot Dev Tools EULA.
  • I understand that if I have a critical issue with ThoughtSpot, I should reach out to my designated Account Executive and Solutions Consultant team instead of cs_tools.
  • I searched the cs_tools documentation, with the integrated search.

Platform Configuration

cs-tools-info-2024-09-12

Description

When performing a cs_tools tools scriptability export on our cluster, when it gets to exporting liveboards this is where issues arise. I was able to modify the source code and grab the outputs where it's failing


FormatConfig(category='CURRENCY', numberFormatConfig=None, percentageFormatConfig=None, currencyFormatConfig={'locale': 'USD', 'unit': 'AUTO', 'decimals': 2.0, 
'toSeparateThousands': True}, customFormatConfig=None, isCategoryEditable=True) category
FormatConfig(category='CURRENCY', numberFormatConfig=None, percentageFormatConfig=None, currencyFormatConfig={'locale': 'USD', 'unit': 'AUTO', 'decimals': 2.0, 
'toSeparateThousands': True}, customFormatConfig=None, isCategoryEditable=True) numberFormatConfig

Need to upload log files securely?

No response

@jmmizerany jmmizerany added the bug Something isn't working label Sep 12, 2024
@boonhapus
Copy link
Collaborator

@jmmizerany This looks like it could be related to thoughtspot_tml#24 , I'll restrict cs_tools to betterproto[compile] < 2.0.0b7 and deploy over the the weekend.

On Monday, please update to 1.5.10 and try your scriptability export again.

curl \
    --silent --show-error --location-trusted \
    https://raw.githubusercontent.com/thoughtspot/cs_tools/master/cs_tools/updater/_bootstrapper.py \
    | python3 - --install

@jmmizerany
Copy link
Contributor Author

@jmmizerany This looks like it could be related to thoughtspot_tml#24 , I'll restrict cs_tools to betterproto[compile] < 2.0.0b7 and deploy over the the weekend.

On Monday, please update to 1.5.10 and try your scriptability export again.

curl \
    --silent --show-error --location-trusted \
    https://raw.githubusercontent.com/thoughtspot/cs_tools/master/cs_tools/updater/_bootstrapper.py \
    | python3 - --install

Great thank you! Also, is this project available for the community to contribute to? If so I don't mind opening a PR to fix this too

@boonhapus
Copy link
Collaborator

boonhapus commented Sep 14, 2024

@jmmizerany it totally is open to the community.. but I also recognize that it's a medium large code base and a 5yr project with plenty of tech debt 😅

This change should be trivial, it's just adding the restriction to pyproject.toml (right now betterproto is transitive via thoughtspot_tml... and will likely go back to transitive once I get some time to fix thoughtspot_tml#24).

@boonhapus
Copy link
Collaborator

pip's a little bit too eager to skip recent betas apparently. We got there with something more explicit though betterproto[compiler] >= 2.0.0b5 , < 2.0.0b7

Try updating to the latest CS Tools and LMK if that resolves your error @jmmizerany

@jmmizerany
Copy link
Contributor Author

pip's a little bit too eager to skip recent betas apparently. We got there with something more explicit though betterproto[compiler] >= 2.0.0b5 , < 2.0.0b7

Try updating to the latest CS Tools and LMK if that resolves your error @jmmizerany

Just verified this works! Thank you! 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants