Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow fe80:: range as a valid ipv6 gateway for public config #911

Open
coesensbert opened this issue Oct 25, 2023 · 8 comments
Open

Allow fe80:: range as a valid ipv6 gateway for public config #911

coesensbert opened this issue Oct 25, 2023 · 8 comments
Milestone

Comments

@coesensbert
Copy link
Contributor

coesensbert commented Oct 25, 2023

Description

Upon setting the public config of a node, allow fe80:: range as 'Gateway IPv6'. This can be a valid configuration if the local setup allows it. Example: fe80::1
image

Temporary workaround

ip netns exec public ip -6 route del default via 2a01:4f8:10a:710::1
ip netns exec public ip -6 route add default via fe80::1 dev public
@coesensbert coesensbert changed the title Allow fe80::1 as a valid ipv6 gateway for public config Allow fe80:: as a valid ipv6 gateway for public config Oct 26, 2023
@coesensbert coesensbert changed the title Allow fe80:: as a valid ipv6 gateway for public config Allow fe80:: range as a valid ipv6 gateway for public config Oct 26, 2023
@ramezsaeed ramezsaeed added this to the 2.3.0 milestone Nov 6, 2023
@zaelgohary
Copy link

Should be done once threefoldtech/tfgrid-sdk-ts#1154 is merged.

@A-Harby
Copy link

A-Harby commented Dec 7, 2023

I tried adding this configuration a couple of times but kept getting that error.

Validation was passing, but after clicking the save button, the error shows up.
image
image

@A-Harby
Copy link

A-Harby commented Dec 7, 2023

Blocked on threefoldtech/tfgrid-sdk-ts#1618

@coesensbert
Copy link
Contributor Author

There is (i believe on-chain?) validation of your added network metrics. Your config from the screenshot can never work. The ip is the same ip as the gateway.

Why you choose to test this specific address? It's already in use. If it's just for testing, make sure to remove those kinds of tests/configs once your done with them.

@A-Harby
Copy link

A-Harby commented Dec 7, 2023

I tried different IPV4 only and it was successful
image
Then I tried the same with fe80::1 and failed.
image

It's probably from chain validation.

@A-Harby A-Harby transferred this issue from threefoldtech/tfgrid-sdk-ts Dec 7, 2023
@A-Harby
Copy link

A-Harby commented Dec 7, 2023

It appears to be from tfchain public IP validation.
image

@xmonader xmonader removed this from 3.13.x Feb 26, 2024
@xmonader xmonader added this to 3.14.x Feb 26, 2024
@xmonader xmonader modified the milestones: 2.3.0, 2.8.0 Feb 26, 2024
@sameh-farouk
Copy link
Member

sameh-farouk commented Jun 2, 2024

I understand that this range is typically used inside an internal network for the router's link-local address and that it is a Valid IPv6 Default Gateway Address as OP stated. I am also aware that these addresses are valid only for communications on a local link (within a subnetwork that a host is connected to) and cannot route on the Internet.
So what is being asked here in this ticket conflicted with what was asked before in this one, which implicitly requires a GW address to be a public IP address (It requires the host IP address to be public and the GW address to be In the same subnet as the host IP address). So I can't implement this one without dropping part of what previously asked by @muhamadazmy
@muhamadazmy @xmonader can you comment here?

@sameh-farouk sameh-farouk removed this from 3.14.x Jun 3, 2024
@sameh-farouk sameh-farouk modified the milestones: 2.8.0, 2.9.0 Jun 3, 2024
@sameh-farouk
Copy link
Member

@delandtj Azamy request your comment. Can you check.

@sameh-farouk sameh-farouk removed this from 3.15.x Jul 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants