Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor the sorting approach #1200

Open
Omarabdul3ziz opened this issue Sep 17, 2024 · 0 comments
Open

refactor the sorting approach #1200

Omarabdul3ziz opened this issue Sep 17, 2024 · 0 comments
Assignees
Labels
grid-proxy belongs to grid proxy refactoring
Milestone

Comments

@Omarabdul3ziz
Copy link
Contributor

instead of filtering based on the sort tag on the resource struct, sometimes we need to apply a sorting that has no equivalent field

_ string `sort:"free_cru"`

It is better to separate the sorting parameters into new types for each resource and validate them against their fields. also separate the sort_by and sort_order from the limit into a new struct which will be integrated only when its needed.

@Omarabdul3ziz Omarabdul3ziz added grid-proxy belongs to grid proxy refactoring labels Sep 17, 2024
@Omarabdul3ziz Omarabdul3ziz added this to the later milestone Sep 17, 2024
@Omarabdul3ziz Omarabdul3ziz self-assigned this Sep 17, 2024
@rawdaGastan rawdaGastan modified the milestones: later, v0.17.x Sep 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
grid-proxy belongs to grid proxy refactoring
Projects
None yet
Development

No branches or pull requests

2 participants