-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Unable to generate short url for signed request #18
Comments
The shortener should support signed requests, you might want to send the URL as a POST parameter instead of being in the URL. Technically speaking the image source should be URL encoded due to the presence of a https://github.com/thumbor-community/shortener/blob/master/tc_shortener/handlers/shortener.py#L65 should let you do a JSON POST to |
There should have been vows/tests covering that. Sorry about the lack of documentation. |
Something seems to be broken, investigating. |
Thanks for looking. Sending the |
Yeah in part. I'm currently adding new tests and fixing a few issues you recently found. For example the shortened url when preserving the file name will use the path basename instead of the full URL. |
Does the shortener support signed requests?
Given a standard thumbor signed request, this works fine:
But, shortening the url fails:
With the logs as follows:
From what I can tell, the call to
yield self.check_image(options)
will fail because the method does not account forshortener
being in the url. It will look like this:The text was updated successfully, but these errors were encountered: