Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rethink Button and Link components #729

Open
danoc opened this issue Oct 29, 2020 · 3 comments
Open

Rethink Button and Link components #729

danoc opened this issue Oct 29, 2020 · 3 comments
Assignees

Comments

@danoc
Copy link
Member

danoc commented Oct 29, 2020

This refers to these four components:

  • Button and ThemedLink
  • Link and TextButton

Problems with the current components

There are a handful of open issues related to these components:

And these are issues that aren't already captured:

  • Link and TextButton don't allow for 100% width.
  • <Link theme="inherit" /> and <TextButton theme="inherit" /> is clunky API and doesn't work for complex layouts.
@danoc
Copy link
Member Author

danoc commented Oct 29, 2020

@dcapo. @lavelle — Does this capture the problems well?

@lavelle
Copy link
Contributor

lavelle commented Nov 11, 2020

Would also be good to add the event argument to the onBlur and onFocus methods of these components, as we do for others like TextArea and Dropdown

@lavelle
Copy link
Contributor

lavelle commented Dec 3, 2020

Original Slack Thread (TT employees only) https://thumbtack.slack.com/archives/C0GKYQVTR/p1603911530021700

@lavelle lavelle self-assigned this Dec 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants