-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Link to Author Webpage #34
Comments
Hi @gserena01 Thank you for raising this feature request. Thinking about the API design, it could potentially be part of a For example:
Would that be useful and is it what you had in mind? Note that the bulk of the effort will most likely be identifying suitable websites for each relevant author. Those will usually not be personal web pages in the strict sense, as the authors currently available on PoetryDB are classic authors whose works are in the public domain. So it will be more about identifying a representative website for each author. In some cases a Wikipedia page might have to suffice. If so, would you be interested in assisting with the task of identifying such websites? |
The info field sounds great! And yes, I would be happy to help find these websites! |
That's great, thank you! The names of all the authors are available at the following URL: If you find a link you like for a particular author, please note it in this thread, for example: Emily Dickinson: https://emilydickinson.com Anyone can submit suggestions. Once the number of links have reached a tipping point, and the functionality has been coded, then the database can be updated. Thanks again for the help. |
Hey why dont you make it part of #hacktoberfest |
@thundercomb Can I take up the coding part of this issue? |
@wweverma1 Thanks for offering, yes please go ahead: create a new branch from master; then a pull request once you're happy and / or would like a review. Once all the code is in place I will add the new data and we're good to go. |
Some suggested tweaks to data format. I agree choosing some reference sources is a much easier task than trying to decide on individual sites, which is inevitably going to be fairly arbitrary--one person's list of the best Shakespeare site(s) is going to differ from another's. Even if we start with a single reference source, we should probably build a data structure that accepts multiple ones. Of course, there are any number of potential reference sites out there that offer info on various poets. Which should we choose? I guess the thoughtful approach would be a two-step process:
Re criteria, I'd suggest to get us started:
It's great to have the list of links for My Poetic Side and having done all that work we should probably run with it. Personally, though, visiting the site, I don't know what to make of it. Who's behind it? I couldn't find any information--no "about us" page or such, at least not as far as I could tell. I'd want to know more before selecting it as a reliable source. Other candidates? There's obviously Wikipedia. Which has its limitations, of course, but they're ones that at least lots of people are fairly aware of. The Poetry Foundation is another obvious candidate. I'd suggest The JSON might look like: [
{
"title": "Not at Home to Callers",
"author": "Emily Dickinson",
"lines": [
"Not at Home to Callers",
"Says the Naked Tree --",
"Bonnet due in April --",
"Wishing you Good Day --"
],
"linecount": "4",
"sources": {
"author": [
{
"My Poetic Side": "https://mypoeticside.com/poets/emily-dickinson-poems",
},
{
"The Poetry Foundation": "https://www.poetryfoundation.org/poets/emily-dickinson",
},
{
"Wikipedia": "https://en.wikipedia.org/wiki/Emily_Dickinson"
}
]
}
}
] A downside of this format is it will repeat {
"name": "Emily Dickinson",
"sources": [
{
"My Poetic Side": "https://mypoeticside.com/poets/emily-dickinson-poems",
},
{
"The Poetry Foundation": "https://www.poetryfoundation.org/poets/emily-dickinson",
},
{
"Wikipedia": "https://en.wikipedia.org/wiki/Emily_Dickinson"
}
]
} |
@nedjo I like that dedicated endpoint idea for If some kind of source ranking is desired in the future I think it would make sense to store each site's domain (and rank) in a dedicated DB table, and a many-to-many table links poet ids, source ids, and URLs. That would provide flexibility to serve non-ranked multiple sources, ranked sources or only a few dedicated domain sources. |
Dear all, I have a request for clarification, and a suggestion. The initial request from @gserena01 was for "a link to a web page with the author's information. Webpage can be authors personal webpages or the webpage from a larger poetry database" Can this be answered with a short bio, and a description of the poet's poetry and influence? From the perspective of the purpose of the PoetryDB website it would be preferable, in my view, if the API offered this as text content rather than a link. Reasons for this include that it would:
Until now it did not seem practical to custom write such information for all 120+ poets on the site. However, having explored this with ChatGPT, my impression is that it is now possible with less effort. ChatGPT appears able to synthesise information about poets both concisely and with a consistency of style. Here are a couple of examples:
While it would still be an undertaking to generate and fact check such a summary for each poet, it now seems more doable. Please let me know your thoughts. |
Gunctionality for including a link to a web page with the author's information. Webpage can be authors personal webpages or the webpage from a larger poetry database
The text was updated successfully, but these errors were encountered: