Is tradeInfo object correct?

[georgezouq]

I check the structure of candidate object's attribute a, b and c. There's a tradeInfo object content side, symbol, quantity.

I print it in TradeCore and I find

the side sames incorrect, If I trade by this, In the first, I sell bnb buy eth, then buy qlc sell bnb and then sell qlc buy eth, eventually, I use 2 time bnb, get 2 time eth(ignore quantity). I think after arbitrage, all trade done. I use 1 bnb should get maybe 1.1 bnb, that 0.1 bnb is profit. But trade by this, its not balance. Or each arbitrage candidate not alone？

[tiagosiebler]

You're correct, if I remember right I noticed this too in an internal branch of this experiment. Each step is a transaction, if you're going to BNB via BNBETH, you'd be buying BNB using ETH. PRs for enhancements & fixes are most welcome if you wish to work on it.