Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add fee commission and modify source code #63

Open
francythepseud opened this issue Mar 14, 2021 · 6 comments
Open

Add fee commission and modify source code #63

francythepseud opened this issue Mar 14, 2021 · 6 comments

Comments

@francythepseud
Copy link

I've modify a fee commission from 0.00075 to 0.030 (this only for test , If I put 0.075 the bot don't work)

LINK → USDT → AUD → LINK | -22.4107%

The bot work but don't are triangular profit.

I think that you idea is correct : insert a new calculation, I rear order book but I take a lot min size and not all lot, but only a part of size, ie:

If I have in order book a quantity of XLM to 5000 , I must take a 500 quantity (for example) not all quantity, if I work with min lot size i've seen that there is some possibile to profit ; If my profit is a 1 x 1000 is ok ; but the bot must be work with min lot size

For velocity i think to integrate a new system as soon as NATS SERVER.

Tiago is it possible to add this? And add personal APIKEY and possibility to make order in my exchange binance?

Otherwise , print your true profit : but ithnik that you haven't a profit

Thanks for all, but I thinks that your bot is ok is true but We must integrated

@francythepseud
Copy link
Author

Only One:

The bot calculate a the first triangular with the fisrt price from order book or update in real time a price from order book?

@tiagosiebler
Copy link
Owner

The bot calculate a the first triangular with the fisrt price from order book or update in real time a price from order book?

It uses the real time bid:ask spread sent via the websocket 24hr symbol tickers.

Tiago is it possible to add this? And add personal APIKEY and possibility to make order in my exchange binance?

I don't have the bandwidth at the moment, but you're welcome try your own approach to this. I'll even try to review pull requests if you make any on this project.

@francythepseud
Copy link
Author

The bot calculate a the first triangular with the fisrt price from order book or update in real time a price from order book?

It uses the real time bid:ask spread sent via the websocket 24hr symbol tickers.

Tiago is it possible to add this? And add personal APIKEY and possibility to make order in my exchange binance?

I don't have the bandwidth at the moment, but you're welcome try your own approach to this. I'll even try to review pull requests if you make any on this project.

Perfect Tiago, thanks for all....

Sorry, not for my exchange but for all is it possibile to add a APIKEY, but there aren't a profit arbitrage

@francythepseud
Copy link
Author

Hi Tiago, but is it possibile to calculate a min lot size for quantity for single crypto? In this mode we have many possibility

I've seen that a BOT calculate all quantity in trinagular for crypto is it true?
But if we calculate a part of quantity (min lot size) we 'll have a many possibility e zero risk

tell me

@towerbuster
Copy link

towerbuster commented Aug 25, 2022

Hi Tiago, but is it possibile to calculate a min lot size for quantity for single crypto? In this mode we have many possibility

I've seen that a BOT calculate all quantity in trinagular for crypto is it true? But if we calculate a part of quantity (min lot size) we 'll have a many possibility e zero risk

tell me

Can this help for the min lot size ?
This needs the ccxt package.

# eg. I want to know what is the minimum allowed for buying BTC/USDT (eg. buying is allowed for a minimum of 10 usdt)
def get_allowed_min_notional(crypto_to_buy, crypto_for_payment):
    print("get_allowed_min_notional: Current market items")
    print("get_allowed_min_notional: Searching if ", crypto_to_buy, "/", crypto_for_payment, " is available for trading")
    symbol_found = False
    # print(exchange.markets.items())
    for line in exchange.markets.items():
        #print("get_allowed_minimum_to_buy: line", line)  # décommenter pour voir les différents assets tradables
        if line[0] == crypto_to_buy + "/" + crypto_for_payment:
            print(crypto_to_buy + "/" + crypto_for_payment, "found (available for trading)")
            symbol_found = True
            print("get_allowed_min_notional: line[1]", line[1]["info"]["filters"])
            for subline in line[1]["info"]["filters"]:
                if subline["filterType"] == "MIN_NOTIONAL":
                    print("get_allowed_min_notional: minimum allowed to buy in", crypto_for_payment, "=", subline["minNotional"])
                    return float(subline["minNotional"])
            break
    if symbol_found is False:
        return -1

@francythepseud
Copy link
Author

francythepseud commented Aug 25, 2022 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants