Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RunCmd() fails when invoked program writes a large amount to stdout (ex. greater than 770K) #129

Open
singweeMsftGitHub opened this issue May 5, 2021 · 0 comments

Comments

@singweeMsftGitHub
Copy link
Contributor

This issue was discovered as part of a hang observed while running a Project Mu LicenseCheck.

The LicenseCheck plug-in calls RunCmd as follows:

return_buffer = StringIO()
params = "diff --unified=0 origin/master HEAD"
RunCmd("git", params, outstream=return_buffer)

RunCmd was found to hang if the diff generates a large amount of text (in my case, greater than 770K).

The following article suggests why this might be the case:
https://thraxil.org/users/anders/posts/2008/03/13/Subprocess-Hanging-PIPE-is-your-enemy/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant