From 10d04deea886a7d7fb52be3a9f350d0b39471e81 Mon Sep 17 00:00:00 2001 From: Mike Maslenkin Date: Mon, 5 Feb 2024 01:11:49 +0300 Subject: [PATCH] RedfishClientPkg: use Json value from a function argument This patch replaces value Private->Json with Json used as second argument for RedfishIdentifyResource(). Currently Json argument is not used at all and the pattern for caller side is: Status = RedfishIdentifyResourceCommon (Private, Private->Json); So in scope of RedfishIdentifyResourceCommon Json actually is the same value as Private->Json. Let's make code a bit cleaner. Cc: Abner Chang Cc: Nickle Wang Cc: Igor Kulchytskyy Signed-off-by: Mike Maslenkin Reviewed-by: Abner Chang Reviewed-by: Nickle Wang --- RedfishClientPkg/Features/Bios/v1_0_9/Common/BiosCommon.c | 2 +- .../Features/BootOption/v1_0_4/Common/BootOptionCommon.c | 2 +- .../ComputerSystem/v1_13_0/Common/ComputerSystemCommon.c | 2 +- .../ComputerSystem/v1_5_0/Common/ComputerSystemCommon.c | 2 +- RedfishClientPkg/Features/Memory/V1_7_1/Common/MemoryCommon.c | 2 +- 5 files changed, 5 insertions(+), 5 deletions(-) diff --git a/RedfishClientPkg/Features/Bios/v1_0_9/Common/BiosCommon.c b/RedfishClientPkg/Features/Bios/v1_0_9/Common/BiosCommon.c index 0ae841499..f3f993c87 100644 --- a/RedfishClientPkg/Features/Bios/v1_0_9/Common/BiosCommon.c +++ b/RedfishClientPkg/Features/Bios/v1_0_9/Common/BiosCommon.c @@ -729,7 +729,7 @@ RedfishIdentifyResourceCommon ( EFI_STRING EndOfChar; REDFISH_FEATURE_ARRAY_TYPE_CONFIG_LANG_LIST ConfigLangList; - Supported = RedfishIdentifyResource (Private->Uri, Private->Json); + Supported = RedfishIdentifyResource (Private->Uri, Json); if (Supported) { Status = RedfishFeatureGetUnifiedArrayTypeConfigureLang (RESOURCE_SCHEMA, RESOURCE_SCHEMA_VERSION, REDPATH_ARRAY_PATTERN, &ConfigLangList); if (EFI_ERROR (Status)) { diff --git a/RedfishClientPkg/Features/BootOption/v1_0_4/Common/BootOptionCommon.c b/RedfishClientPkg/Features/BootOption/v1_0_4/Common/BootOptionCommon.c index 0b9f2bf28..f471c01c3 100644 --- a/RedfishClientPkg/Features/BootOption/v1_0_4/Common/BootOptionCommon.c +++ b/RedfishClientPkg/Features/BootOption/v1_0_4/Common/BootOptionCommon.c @@ -791,7 +791,7 @@ RedfishIdentifyResourceCommon ( { BOOLEAN Supported; - Supported = RedfishIdentifyResource (Private->Uri, Private->Json); + Supported = RedfishIdentifyResource (Private->Uri, Json); if (Supported) { return EFI_SUCCESS; } diff --git a/RedfishClientPkg/Features/ComputerSystem/v1_13_0/Common/ComputerSystemCommon.c b/RedfishClientPkg/Features/ComputerSystem/v1_13_0/Common/ComputerSystemCommon.c index cee6c8bf9..d69fc176a 100644 --- a/RedfishClientPkg/Features/ComputerSystem/v1_13_0/Common/ComputerSystemCommon.c +++ b/RedfishClientPkg/Features/ComputerSystem/v1_13_0/Common/ComputerSystemCommon.c @@ -848,7 +848,7 @@ RedfishIdentifyResourceCommon ( EFI_STRING EndOfChar; REDFISH_FEATURE_ARRAY_TYPE_CONFIG_LANG_LIST ConfigLangList; - Supported = RedfishIdentifyResource (Private->Uri, Private->Json); + Supported = RedfishIdentifyResource (Private->Uri, Json); if (Supported) { Status = RedfishFeatureGetUnifiedArrayTypeConfigureLang (RESOURCE_SCHEMA, RESOURCE_SCHEMA_VERSION, REDPATH_ARRAY_PATTERN, &ConfigLangList); if (EFI_ERROR (Status)) { diff --git a/RedfishClientPkg/Features/ComputerSystem/v1_5_0/Common/ComputerSystemCommon.c b/RedfishClientPkg/Features/ComputerSystem/v1_5_0/Common/ComputerSystemCommon.c index a67ef3dac..11bcb5f76 100644 --- a/RedfishClientPkg/Features/ComputerSystem/v1_5_0/Common/ComputerSystemCommon.c +++ b/RedfishClientPkg/Features/ComputerSystem/v1_5_0/Common/ComputerSystemCommon.c @@ -1718,7 +1718,7 @@ RedfishIdentifyResourceCommon ( EFI_STRING EndOfChar; REDFISH_FEATURE_ARRAY_TYPE_CONFIG_LANG_LIST ConfigLangList; - Supported = RedfishIdentifyResource (Private->Uri, Private->Json); + Supported = RedfishIdentifyResource (Private->Uri, Json); if (Supported) { Status = RedfishFeatureGetUnifiedArrayTypeConfigureLang (RESOURCE_SCHEMA, RESOURCE_SCHEMA_VERSION, REDPATH_ARRAY_PATTERN, &ConfigLangList); if (EFI_ERROR (Status)) { diff --git a/RedfishClientPkg/Features/Memory/V1_7_1/Common/MemoryCommon.c b/RedfishClientPkg/Features/Memory/V1_7_1/Common/MemoryCommon.c index eb52c68c5..00a69f748 100644 --- a/RedfishClientPkg/Features/Memory/V1_7_1/Common/MemoryCommon.c +++ b/RedfishClientPkg/Features/Memory/V1_7_1/Common/MemoryCommon.c @@ -2516,7 +2516,7 @@ RedfishIdentifyResourceCommon ( EFI_STRING EndOfChar; REDFISH_FEATURE_ARRAY_TYPE_CONFIG_LANG_LIST ConfigLangList; - Supported = RedfishIdentifyResource (Private->Uri, Private->Json); + Supported = RedfishIdentifyResource (Private->Uri, Json); if (Supported) { Status = RedfishFeatureGetUnifiedArrayTypeConfigureLang (RESOURCE_SCHEMA, RESOURCE_SCHEMA_VERSION, REDPATH_ARRAY_PATTERN, &ConfigLangList); if (EFI_ERROR (Status)) {