Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Define an "approved" PR #48

Open
Tracked by #36
makubacki opened this issue Jun 15, 2023 · 1 comment
Open
Tracked by #36

Define an "approved" PR #48

makubacki opened this issue Jun 15, 2023 · 1 comment

Comments

@makubacki
Copy link
Member

makubacki commented Jun 15, 2023 •
edited
Loading

  • At least one reviewer from each package in the PR series has approved
  • All comments are resolved
  • All PR status checks are succcessful
  • The PR has been made available for at least 24 hours from the time of its creation
@makubacki makubacki mentioned this issue Jun 15, 2023
Open
@mdkinney
Copy link
Member

The minimum time is 24 hours. Small changes are allowed to be finished within this minimum time. Larger changes and new features should have a minimum of 1 week unless it is a critical issue that is blocking CI or development

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
Pull Requests
Status: No status
Milestone
No milestone
Development

No branches or pull requests
2 participants
@mdkinney @makubacki