Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Define mechanism to ensure PRs are moved quickly after approval #54

Open
Tracked by #36
makubacki opened this issue Jun 15, 2023 · 2 comments
Open
Tracked by #36

Define mechanism to ensure PRs are moved quickly after approval #54

makubacki opened this issue Jun 15, 2023 · 2 comments

Comments

@makubacki
Copy link
Member

makubacki commented Jun 15, 2023

It is often a problem that code is approved and ready for completion but it is not clear who is supposed to actually push the code. The goal of this task is to define a process that makes it clear what happens and prevents this unnecessary gap in the contribution process.

@makubacki
Copy link
Member Author

@mdkinney, I don't recall a resolution being reached on this topic.

@mdkinney
Copy link
Member

The first approach will be same as today. One of the maintainers will have to notice that all of the required reviews for the entire PR have been completed and that all CI checks pass and that all conversations are resolved and set the "push" label.

We are open to adding more automation and process, but no clear direction on that at this time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: No status
Development

No branches or pull requests

2 participants