From df0c2dcb46c8fe2d056cf93873039a60161f2b43 Mon Sep 17 00:00:00 2001 From: Jeremy Karlsson Date: Tue, 5 Mar 2024 14:44:09 +0100 Subject: [PATCH 1/4] Add Cypress back --- .github/{disabled-workflows => workflows}/cypress.yml | 0 1 file changed, 0 insertions(+), 0 deletions(-) rename .github/{disabled-workflows => workflows}/cypress.yml (100%) diff --git a/.github/disabled-workflows/cypress.yml b/.github/workflows/cypress.yml similarity index 100% rename from .github/disabled-workflows/cypress.yml rename to .github/workflows/cypress.yml From d06d5a3355f8c1f98b38d1c03541975d6ba5bfc1 Mon Sep 17 00:00:00 2001 From: Jeremy Karlsson Date: Tue, 5 Mar 2024 14:45:20 +0100 Subject: [PATCH 2/4] force run on pr --- .github/workflows/cypress.yml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/.github/workflows/cypress.yml b/.github/workflows/cypress.yml index ac251772..e61d71a6 100644 --- a/.github/workflows/cypress.yml +++ b/.github/workflows/cypress.yml @@ -5,12 +5,12 @@ name: Cypress Tests # (Auth is provided via credentials provider and not directly used) on: push: - branches: [ "main" ] + branches: [ "main", "re-enable-cypress" ] paths: - packages/true-time/** - packages/player/** pull_request: - branches: [ "main"] + branches: [ "main", "re-enable-cypress" ] paths: - packages/true-time/** - packages/player/** From 21878cbc7b3b2e1638820544ef65719f3f602e67 Mon Sep 17 00:00:00 2001 From: Jeremy Karlsson Date: Tue, 5 Mar 2024 14:47:41 +0100 Subject: [PATCH 3/4] Trigger change in pkg --- .github/workflows/cypress.yml | 4 ++-- packages/player/README.md | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/.github/workflows/cypress.yml b/.github/workflows/cypress.yml index e61d71a6..662c9034 100644 --- a/.github/workflows/cypress.yml +++ b/.github/workflows/cypress.yml @@ -5,12 +5,12 @@ name: Cypress Tests # (Auth is provided via credentials provider and not directly used) on: push: - branches: [ "main", "re-enable-cypress" ] + branches: [ "main" ] paths: - packages/true-time/** - packages/player/** pull_request: - branches: [ "main", "re-enable-cypress" ] + branches: [ "main" ] paths: - packages/true-time/** - packages/player/** diff --git a/packages/player/README.md b/packages/player/README.md index 658c1fe0..421aac9a 100644 --- a/packages/player/README.md +++ b/packages/player/README.md @@ -32,7 +32,7 @@ To load TIDAL Player into a project locally without publishing to npm; using `pn 1. Open the package.json in the project. (in the case of webclient, the root one) 2. Add or edit a `"resolutions"` property on the top level. (this is an object) -3. Add an entry for @tidal-music/player like so: `"@tidal-music/player": "file:/Users/yourusername/dev/tidal-sdk-web/packages/player"` +3. Add an entry for @tidal-music/player like so: `"@tidal-music/player": "file:/Users//dev/tidal-sdk-web/packages/player"` 4. Run `npm/yarn/pnpm install` in your destination project. !! Remove the entry in `"resolution"` and run `npm/yarn/pnpm install` again when you are done testing to have the NPM version of the package load instead. From 58b82a76b3b5a144776d56cf049b2d3ca72e9ea6 Mon Sep 17 00:00:00 2001 From: Jeremy Karlsson Date: Wed, 6 Mar 2024 11:58:26 +0100 Subject: [PATCH 4/4] Add back step "Set up Cypress binary cache" --- .github/workflows/cypress.yml | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/.github/workflows/cypress.yml b/.github/workflows/cypress.yml index 662c9034..802d4dd6 100644 --- a/.github/workflows/cypress.yml +++ b/.github/workflows/cypress.yml @@ -26,7 +26,6 @@ jobs: - name: Checkout uses: actions/checkout@v4 - uses: ./.github/actions/setup - - uses: ./.github/actions/build-projects - name: Prepare test user for player tests id: json run: | @@ -38,6 +37,11 @@ jobs: echo "encoded=\"$encoded_json\"" >> $GITHUB_OUTPUT env: TEST_USER: ${{ secrets.PLAYER_TEST_USER }} + - name: Set up Cypress binary cache + uses: actions/cache@v4 + with: + path: ~/.cache/Cypress + key: ${{ runner.os }}-cypress-${{ hashFiles('pnpm-lock.yaml') }} - name: Cypress run uses: cypress-io/github-action@v6 env: