From 48cc38f025e2971619273ef824e35849144046c7 Mon Sep 17 00:00:00 2001 From: Davis Vaughan Date: Mon, 26 Sep 2022 08:48:33 -0400 Subject: [PATCH] workflows 1.1.0 (#173) * Update revdepcheck results * Increment version number to 1.1.0 * Update `cran-comments.md` with revdepcheck issues * CRAN-SUBMISSION * Update `cran-comments.md` * CRAN-SUBMISSION * delete CRAN-SUBMISSION Co-authored-by: simonpcouch --- DESCRIPTION | 2 +- NEWS.md | 2 +- cran-comments.md | 18 ++++-- revdep/README.md | 8 +++ revdep/cran.md | 18 +++++- revdep/problems.md | 135 ++++++++++++++++++++++++++++++++++++++++++++- 6 files changed, 173 insertions(+), 10 deletions(-) diff --git a/DESCRIPTION b/DESCRIPTION index d4440ebf..255c5311 100644 --- a/DESCRIPTION +++ b/DESCRIPTION @@ -1,6 +1,6 @@ Package: workflows Title: Modeling Workflows -Version: 1.0.0.9000 +Version: 1.1.0 Authors@R: c( person("Davis", "Vaughan", , "davis@rstudio.com", role = "aut"), person("Simon", "Couch", , "simonpatrickcouch@gmail.com", role = c("aut", "cre"), diff --git a/NEWS.md b/NEWS.md index bd3589a3..d6ac9722 100644 --- a/NEWS.md +++ b/NEWS.md @@ -1,4 +1,4 @@ -# workflows (development version) +# workflows 1.1.0 * Simon Couch is now the maintainer (#170). diff --git a/cran-comments.md b/cran-comments.md index 37e98a95..81a8bf01 100644 --- a/cran-comments.md +++ b/cran-comments.md @@ -1,7 +1,15 @@ -## revdepcheck results +## Known problems -We checked 28 reverse dependencies (26 from CRAN + 2 from Bioconductor), comparing R CMD check results across CRAN and dev versions of this package. - - * We saw 0 new problems - * We failed to check 0 packages +All 3 broken packages are from the same maintainer. He was notified of this issue two weeks ago. +* modeltime + * Description: Error in tests + * Link: https://github.com/business-science/modeltime/pull/198 + +* modeltime.ensemble + * Description: Error in tests + * Link: See modeltime + +* modeltime.resample + * Description: Error in vignettes + * Link: See modeltime diff --git a/revdep/README.md b/revdep/README.md index fb3df086..9f440d79 100644 --- a/revdep/README.md +++ b/revdep/README.md @@ -7,3 +7,11 @@ |NA |? | | | | |NA |? | | | | +## New problems (3) + +|package |version |error |warning |note | +|:------------------|:-------|:------|:-------|:----| +|[modeltime](problems.md#modeltime)|1.2.2 |__+1__ | | | +|[modeltime.ensemble](problems.md#modeltimeensemble)|1.0.1 |__+1__ | |1 | +|[modeltime.resample](problems.md#modeltimeresample)|0.2.1 | |__+1__ |1 | + diff --git a/revdep/cran.md b/revdep/cran.md index 37e98a95..10eec90b 100644 --- a/revdep/cran.md +++ b/revdep/cran.md @@ -1,7 +1,21 @@ ## revdepcheck results -We checked 28 reverse dependencies (26 from CRAN + 2 from Bioconductor), comparing R CMD check results across CRAN and dev versions of this package. +We checked 29 reverse dependencies (27 from CRAN + 2 from Bioconductor), comparing R CMD check results across CRAN and dev versions of this package. - * We saw 0 new problems + * We saw 3 new problems * We failed to check 0 packages +Issues with CRAN packages are summarised below. + +### New problems +(This reports the first line of each new failure) + +* modeltime + checking tests ... ERROR + +* modeltime.ensemble + checking tests ... ERROR + +* modeltime.resample + checking re-building of vignette outputs ... WARNING + diff --git a/revdep/problems.md b/revdep/problems.md index 9a207363..7ad4b96d 100644 --- a/revdep/problems.md +++ b/revdep/problems.md @@ -1 +1,134 @@ -*Wow, no problems at all. :)* \ No newline at end of file +# modeltime + +
+ +* Version: 1.2.2 +* GitHub: https://github.com/business-science/modeltime +* Source code: https://github.com/cran/modeltime +* Date/Publication: 2022-06-07 21:50:02 UTC +* Number of recursive dependencies: 243 + +Run `cloud_details(, "modeltime")` for more info + +
+ +## Newly broken + +* checking tests ... ERROR + ``` + Running ‘testthat.R’ + Running the tests in ‘tests/testthat.R’ failed. + Last 13 lines of output: + Backtrace: + ▆ + 1. ├─... %>% fit(data_set) at test-panel-data.R:33:0 + 2. ├─generics::fit(., data_set) + 3. ├─workflows::add_recipe(., recipe_spec %>% step_rm(date)) + 4. │ └─workflows:::add_action(x, action, "recipe") + 5. │ └─workflows:::validate_is_workflow(x, call = call) + 6. │ └─workflows:::is_workflow(x) + 7. └─workflows::add_model(., svm_rbf() %>% set_engine("kernlab")) + 8. └─workflows:::new_action_model(spec, formula) + 9. └─rlang::abort(message, call = call) + + [ FAIL 2 | WARN 2 | SKIP 22 | PASS 477 ] + Error: Test failures + Execution halted + ``` + +# modeltime.ensemble + +
+ +* Version: 1.0.1 +* GitHub: https://github.com/business-science/modeltime.ensemble +* Source code: https://github.com/cran/modeltime.ensemble +* Date/Publication: 2022-06-09 12:20:02 UTC +* Number of recursive dependencies: 214 + +Run `cloud_details(, "modeltime.ensemble")` for more info + +
+ +## Newly broken + +* checking tests ... ERROR + ``` + Running ‘testthat.R’ + Running the tests in ‘tests/testthat.R’ failed. + Last 13 lines of output: + Backtrace: + ▆ + 1. ├─... %>% fit(data_set) at test-panel-data.R:28:0 + 2. ├─generics::fit(., data_set) + 3. ├─workflows::add_recipe(., recipe_spec %>% step_rm(date)) + 4. │ └─workflows:::add_action(x, action, "recipe") + 5. │ └─workflows:::validate_is_workflow(x, call = call) + 6. │ └─workflows:::is_workflow(x) + 7. └─workflows::add_model(., boost_tree() %>% set_engine("xgboost")) + 8. └─workflows:::new_action_model(spec, formula) + 9. └─rlang::abort(message, call = call) + + [ FAIL 2 | WARN 16 | SKIP 5 | PASS 52 ] + Error: Test failures + Execution halted + ``` + +## In both + +* checking dependencies in R code ... NOTE + ``` + Namespace in Imports field not imported from: ‘parsnip’ + All declared Imports should be used. + ``` + +# modeltime.resample + +
+ +* Version: 0.2.1 +* GitHub: https://github.com/business-science/modeltime.resample +* Source code: https://github.com/cran/modeltime.resample +* Date/Publication: 2022-06-07 14:30:03 UTC +* Number of recursive dependencies: 212 + +Run `cloud_details(, "modeltime.resample")` for more info + +
+ +## Newly broken + +* checking re-building of vignette outputs ... WARNING + ``` + Error(s) in re-building vignettes: + --- re-building ‘getting-started.Rmd’ using rmarkdown + ── Attaching packages ────────────────────────────────────── tidymodels 1.0.0 ── + ✔ broom 1.0.1 ✔ recipes 1.0.1 + ✔ dials 1.0.0 ✔ rsample 1.1.0 + ✔ dplyr 1.0.10 ✔ tibble 3.1.8 + ✔ ggplot2 3.3.6 ✔ tidyr 1.2.1 + ✔ infer 1.0.3 ✔ tune 1.0.0 + ✔ modeldata 1.0.1 ✔ workflows 1.1.0 + ✔ parsnip 1.0.1 ✔ workflowsets 1.0.0 + ... + Error: processing vignette 'panel-data.Rmd' failed with diagnostics: + `spec` must have a known mode. + ℹ Set the mode of `spec` by using `parsnip::set_mode()` or by setting the mode directly in the parsnip specification function. + --- failed re-building ‘panel-data.Rmd’ + + SUMMARY: processing the following file failed: + ‘panel-data.Rmd’ + + Error: Vignette re-building failed. + Execution halted + ``` + +## In both + +* checking dependencies in R code ... NOTE + ``` + Namespaces in Imports field not imported from: + ‘crayon’ ‘dials’ ‘glue’ ‘parsnip’ + All declared Imports should be used. + ``` +