Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Example assumes DBI (>= 1.2.0) #324

Closed
MichaelChirico opened this issue May 22, 2024 · 2 comments
Closed

Example assumes DBI (>= 1.2.0) #324

MichaelChirico opened this issue May 22, 2024 · 2 comments

Comments

@MichaelChirico
Copy link
Contributor

DBI::Id(iris_db, "sepal_length"),

Per the NEWS, this style is only valid from DBI v1.2.0:

Id() now accepts unnamed components (#417). If names are provided, the components are arranged in SQL order (@eauleaf, #427).

But {glue} doesn't have that version stated.

The easiest fix is just to bump the minimum version, but OTOH, is it worth bumping the version requirement just for examples? I leave it up to maintainers :)

@jennybc
Copy link
Member

jennybc commented Jul 16, 2024

Another observation: DBI is only listed in Suggests and, while some methods of "install all my dependencies" might honor a minimum version for a suggested package, I think most don't. So this is a signal mostly aimed at humans.

In any case, this change has already been made in the dev version of glue: 84ea088.

@jennybc jennybc closed this as completed Jul 16, 2024
@MichaelChirico
Copy link
Contributor Author

I think most don't

I think you're right -- but even if they don't, they "should", and we can expect it'll be true "eventually"... just that we have no way of detecting any backsliding in the meantime (besides reports from folks like me that install from weird environments 😃)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants