Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve handling of Github errors #124

Open
marcusmoore opened this issue Jul 13, 2021 · 0 comments
Open

Improve handling of Github errors #124

marcusmoore opened this issue Jul 13, 2021 · 0 comments
Labels
bug Something isn't working

Comments

@marcusmoore
Copy link
Contributor

This is rare but Github doesn't always return JSON when we're expecting it and throws an uncaught exception.

One place this happens is when the SyncPackageRepositoryData job is called. We end up calling app/GitHubRepo::latestRelease() which returns HTML that includes the string We had issues producing the response to your request. Sorry about that. Please try refreshing and contact us if the problem persists.

We can probably check to see if we got an error response and send another request to see if it was just bad luck.

@marcusmoore marcusmoore added the bug Something isn't working label Jul 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant