Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dashboard : common.bad_request isn't meaningful #6729

Closed
AricSu opened this issue Jun 30, 2023 · 2 comments
Closed

Dashboard : common.bad_request isn't meaningful #6729

AricSu opened this issue Jun 30, 2023 · 2 comments
Labels
type/enhancement The issue or PR belongs to an enhancement.

Comments

@AricSu
Copy link

AricSu commented Jun 30, 2023

Enhancement Task

when customer uses dashboard to export slow.log or tidb.log. This error named common.bad_request isn't meaningful.
I'm gonna list two scenarios I met to show why
image

  1. Dump slow queries failed because of priv limit.
    image

  2. Slow query download from the TiDB dashboard was failing due to OOM at tidb server, customer had to increase tidb_mem_quota_query for the download worked.
    More info : https://pingcap.zendesk.com/agent/tickets/1910

Please let this error more understandable, thx!
@AricSu AricSu added the type/enhancement The issue or PR belongs to an enhancement. label Jun 30, 2023
@rleungx
Copy link
Member

rleungx commented Jun 30, 2023 •
edited
Loading

@jansu-dev Do we need to move it to tidb-dashboard repo?

@AricSu
Copy link
Author

AricSu commented Jun 30, 2023

@jansu-dev Do we need to move it to tidb-dashboard repo?

Sure, I create another one there. pingcap/tidb-dashboard#1553
If it should be processed in tidb-dashboard repo, you can directly close this one.

@rleungx rleungx closed this as completed Jun 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
type/enhancement The issue or PR belongs to an enhancement.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@rleungx @AricSu