From 5a22245ed1e4d2416c78c4d9fdc6013551406dd7 Mon Sep 17 00:00:00 2001 From: Cabinfever_B Date: Mon, 18 Mar 2024 13:17:31 +0800 Subject: [PATCH 1/2] remove failed request metrics for background quert Signed-off-by: Cabinfever_B --- client/resource_group/controller/controller.go | 2 -- 1 file changed, 2 deletions(-) diff --git a/client/resource_group/controller/controller.go b/client/resource_group/controller/controller.go index 241e4ab81bf..4f4f15c48db 100755 --- a/client/resource_group/controller/controller.go +++ b/client/resource_group/controller/controller.go @@ -563,7 +563,6 @@ func (c *ResourceGroupsController) IsBackgroundRequest(ctx context.Context, resourceGroupName, requestResource string) bool { gc, err := c.tryGetResourceGroup(ctx, resourceGroupName) if err != nil { - failedRequestCounter.WithLabelValues(resourceGroupName).Inc() return false } @@ -576,7 +575,6 @@ func (c *ResourceGroupsController) checkBackgroundSettings(ctx context.Context, resourceGroupName := "default" gc, err := c.tryGetResourceGroup(ctx, resourceGroupName) if err != nil { - failedRequestCounter.WithLabelValues(resourceGroupName).Inc() return false } bg = gc.getMeta().BackgroundSettings From dc915fe90bc7868161fc54dd894783eba55f3899 Mon Sep 17 00:00:00 2001 From: Cabinfever_B Date: Mon, 18 Mar 2024 13:25:17 +0800 Subject: [PATCH 2/2] remove failed request metrics for background quert Signed-off-by: Cabinfever_B --- tests/integrations/mcs/resourcemanager/resource_manager_test.go | 1 + 1 file changed, 1 insertion(+) diff --git a/tests/integrations/mcs/resourcemanager/resource_manager_test.go b/tests/integrations/mcs/resourcemanager/resource_manager_test.go index 076e9b99531..41b637aba51 100644 --- a/tests/integrations/mcs/resourcemanager/resource_manager_test.go +++ b/tests/integrations/mcs/resourcemanager/resource_manager_test.go @@ -1271,6 +1271,7 @@ func (suite *resourceManagerClientTestSuite) TestCheckBackgroundJobs() { re.False(c.IsBackgroundRequest(suite.ctx, resourceGroupName, "internal_lightning")) re.False(c.IsBackgroundRequest(suite.ctx, resourceGroupName, "internal_ddl")) re.False(c.IsBackgroundRequest(suite.ctx, resourceGroupName, "")) + re.False(c.IsBackgroundRequest(suite.ctx, "none", "none")) resourceGroupName = enableBackgroundGroup(true) re.True(c.IsBackgroundRequest(suite.ctx, resourceGroupName, "internal_br"))