Installing from source fails on Windows (UnicodeDecodeError)

[davnn]

Hi everyone,

trying to install the package from source does not work for on Windows 10; it fails with UnicodeDecodeError: 'charmap' codec can't decode byte 0x8f in position [...]. The problem also affects other packages (e.g. iitzco/faced#21), but is easily solved by specifying an encoding in the setup.py, see PR.

[oguiza]

Thanks for sharing this issue and submitting a PR!
I'll review and approve asap.

[oguiza]

Hi @davnn,
I've just merged your PR.
It'd be great if you could test it on a Windows machine (I don't have any available).

[davnn]

Hi @davnn,

I've just merged your PR.

It'd be great if you could test it on a Windows machine (I don't have any available).

I did (on my machine), seems to work fine 👍🏼. Thanks for the quick merge.

[oguiza]

Thanks a lot @davnn for submitting the PR!
Based on your feedback, I'll close this issue.