Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add configuration to handle custom certificate #49

Open
Akendo opened this issue Nov 14, 2022 · 2 comments
Open

Add configuration to handle custom certificate #49

Akendo opened this issue Nov 14, 2022 · 2 comments

Comments

@Akendo
Copy link

Akendo commented Nov 14, 2022

HI,

First of all, thanks for this project!

I'm using my certificate from task warrior to handle this. I wish I could change this parameter within the configuration file to point to the given file instead of the hard-coded public_key.pem or private_key.pem files.

Maybe I'm holding it wrong, but if otherwise, it should be documented.

Thanks anyway,
best regards

@vstollen
Copy link
Contributor

Hi Akendo,

reusing and supporting Taskwarrior certificates sounds like a useful addition!

Unfortunately, I am not an expert in cryptography. Before promoting this, I would like to make sure that the certificates used are compatible.

If someone has a good resource to better understand PEM files, certificates and keys, please let me know!

@Akendo
Copy link
Author

Akendo commented Nov 25, 2022

Your answer surprises me a bit, considering the fact that you're using JWT, which requires asymmetric types of keys.

As long your certificate is x509 compilable, this shouldn't be much of a concern. PEM files are just a coding format to contain the x and y ( y which is often quite static away) parameters of your asymmetric keys, with some additional PKI information. What is relevant for us at this stage is the key/certificate.

So, it might be necessary to add also key size and format to the configuration?

I might need to review your usage of JWT. So far, it seems to more like you copy and pasted the default example with slight adjustments.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants