cleanup comments

Signed-off-by: Tim Vaillancourt <[email protected]>

go/vt/vtorc/logic/keyspace_shard_discovery.go

@@ -170,6 +170,8 @@ func refreshAllShards(ctx context.Context, keyspaceName string) error {
 		log.Error(err)
 		return err
 	}
+
+	// save shards that should be watched.
 	savedShards := make(map[string]bool, len(shardInfos))
 	for _, shardInfo := range shardInfos {
 		if !shouldWatchShard(shardInfo) {
@@ -182,10 +184,10 @@ func refreshAllShards(ctx context.Context, keyspaceName string) error {
 		savedShards[shardInfo.ShardName()] = true
 	}
 
-	// delete shards that were not returned by ts.FindAllShardsInKeyspace(...),
-	// indicating they are stale.
+	// delete shards that were not saved, indicating they are stale.
 	shards, err := inst.ReadShardNames(keyspaceName)
 	if err != nil {
+		log.Error(err)
 		return err
 	}
 	for _, shard := range shards {

go/vt/vtorc/logic/keyspace_shard_discovery_test.go

@@ -56,11 +56,9 @@ func TestRefreshAllKeyspaces(t *testing.T) {
 	// Store the old flags and restore on test completion
 	oldTs := ts
 	oldClustersToWatch := clustersToWatch
-	oldShardsToWatch := shardsToWatch
 	defer func() {
 		ts = oldTs
 		clustersToWatch = oldClustersToWatch
-		shardsToWatch = oldShardsToWatch
 	}()
 
 	db.ClearVTOrcDatabase()
@@ -317,11 +315,9 @@ func verifyPrimaryAlias(t *testing.T, keyspaceName, shardName string, primaryAli
 func TestRefreshAllShards(t *testing.T) {
 	// Store the old flags and restore on test completion
 	oldClustersToWatch := clustersToWatch
-	oldShardsToWatch := shardsToWatch
 	oldTs := ts
 	defer func() {
 		clustersToWatch = oldClustersToWatch
-		shardsToWatch = oldShardsToWatch
 		ts = oldTs
 		db.ClearVTOrcDatabase()
 	}()