Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Accessors for SASLib handler object #29

Open
tk3369 opened this issue Feb 11, 2018 · 2 comments
Open

Accessors for SASLib handler object #29

tk3369 opened this issue Feb 11, 2018 · 2 comments

Comments

@tk3369
Copy link
Owner

tk3369 commented Feb 11, 2018

When reading a file incrementally, the open function returns a SASLib.Handler object. Honestly, this struct is somewhat heavy and and probably not very well designed. From a data encapsulation perspective, it would be nice to have some accessor functions that returns commonly used data, like those already being displayed from the show function:

julia> h
SASLib.Handler:
  filename:    data_pandas/productsales.sas7bdat
  encoding:    US-ASCII
  platform:    9.0301M2 (32-bit)
  endianness:  LittleEndian
  page size:   8192
  pages:       18
  rows:        1440
  cols:        10
@tk3369
Copy link
Owner Author

tk3369 commented Mar 7, 2018

It's probably better to encapsulate the internal state with a wrapper object with minimal exposed data. With the new metadata function, there's no reason to get meta information from the handler object.

@tk3369
Copy link
Owner Author

tk3369 commented Jan 1, 2020

Probably a better option is to implement properties for the handler object so we can expose useful fields.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant