Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

InternedStrings.jl vs ObjectPool #34

Open
xiaodaigh opened this issue Feb 21, 2018 · 2 comments
Open

InternedStrings.jl vs ObjectPool #34

xiaodaigh opened this issue Feb 21, 2018 · 2 comments

Comments

@xiaodaigh
Copy link
Contributor

It might be worthwhile documenting why the ObjectPool approach was used instead of the InternedStrings.jl. A pros and cons write down so that the decisions are remembered.

@tk3369
Copy link
Owner

tk3369 commented Feb 21, 2018

See #4 for previous discussions. I wasn't aware of the InternedStrings.jl package. I benchmarked CategoricalArray, PooledArray, and ObjectPool and ended up keeping the ObjectPool implementation. On the other hand, you can easily define a custom array type that holds InternedStrings and pass the respective fill function to SASLib. In the setindex! function, you can make InternedStrings.

@tk3369
Copy link
Owner

tk3369 commented Mar 7, 2018

Leaving this issue open for performance benchmarking. Not a priority compared to other issues and I would probably do this after Julia v0.7 is officially released.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants