Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Not all color themes are updated for v2 #242

Closed
chomskysfavefive opened this issue May 8, 2024 · 8 comments · Fixed by #249
Closed

Not all color themes are updated for v2 #242

chomskysfavefive opened this issue May 8, 2024 · 8 comments · Fixed by #249

Comments

@chomskysfavefive
Copy link

Dracula theme does not apply. Everything about my hardware and software is the same as yesterday, the only thing that changed was that I updated AdwSteamGTK to 2.0.

Steps to reproduce:

  1. Exit Steam.
  2. Install Dracula theme
  3. Open Steam to a generic Adwaita theme without Dracula color palette. This is not expected behavior.
@chomskysfavefive
Copy link
Author

The libraryroot css file shows that the Dracula theme is applied, but it's not. The colors.css seems like it's the generic Adwaita palette, not the Dracula palette.

@chomskysfavefive
Copy link
Author

Also the web page part of the client is not themed at all.

Screenshot from 2024-05-08 00-39-05

@Foldex
Copy link
Contributor

Foldex commented May 8, 2024

Looks like most themes haven't been updated to the new format yet.
Aside from the below, the rest are going to be broken.

Updated Themes
Adwaita
Breeze
Canta
Catppuccin-Frappe
Yaru

@chomskysfavefive
Copy link
Author

Copy that, thanks so much!

@chomskysfavefive
Copy link
Author

Using the updated themes now as a demo. Fantastic work. The hover menus near the hamburger menu button are working great.

@eylles
Copy link

eylles commented May 8, 2024

i cobbled a template for using with pywal on #205 (comment) and i'm currently prototyping a python script to read a json file with colors from either pywal or gradience (that part of the script is already done) and was working on cobbling a template for the css for said script, if you would be so kind to direct me which is the correct css to use as template OR if the custom css is no longer going to be supported an example of how to add another color theme (if there is more to it than creating a directory under colorthemes with the right css)

@tkashkin tkashkin changed the title Dracula theme not applying Not all color themes are updated for v2 May 8, 2024
@tkashkin
Copy link
Owner

tkashkin commented May 8, 2024

@eylles

which is the correct css to use as template

Either adwaita/css/_root/colors.css or adwaita/colorthemes/adwaita/adwaita.css, both are the same. They define all theme colors which are mostly taken from the libadwaita stylesheet.
There are a few other variables defined in adwaita/css/_root.

how to add another color theme (if there is more to it than creating a directory under colorthemes with the right css)

Create adwaita/colorthemes/$name/$name.css and it should be detected by the installer script.

@eylles
Copy link

eylles commented May 9, 2024

@tkashkin thanks for your input, hope to have it ready for the weekend.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants