Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nested Dict Spaces or Multidimensional arrays #58

Open
prototact opened this issue May 25, 2022 · 12 comments
Open

Nested Dict Spaces or Multidimensional arrays #58

prototact opened this issue May 25, 2022 · 12 comments

Comments

@prototact
Copy link
Contributor

prototact commented May 25, 2022

Hi,

  • Is it possible to nest Dict Spaces?
  • Is it possible for boxes to be multi-dimensional arrays? Matrices would be good enough.
@prototact prototact changed the title Nested Dict Spaces Nested Dict Spaces or Multidimensional arrays May 25, 2022
@Abdelkader-gnichi
Copy link

hi @prototact did manage to make it with multi-dimensional ?

@prototact
Copy link
Contributor Author

I had to modify the python code but it worked yes. I can share later if you'd like.

@pgawlowicz
Copy link
Contributor

Hi @prototact, could you provide a patch for the ns3gym?

@Abdelkader-gnichi
Copy link

@prototact yes please can you share your modification cos i need it this period to complete my master project and thank you a lot for your response

@Abdelkader-gnichi
Copy link

Hi @pgawlowicz i hope that you doing well,

Did you have any implementations or small complet exemple of multi agent learning in ns3-gym, and if you have an example about ns3-gym with ofswitch13 package cos my project is about configure a bunch of switches that receiving udp traffic to make it reach its final destination based on DRL agent decisions (the decisions is an output port for each switch that have an incoming traffic on its ports)

Again i want to thank you about your massive work on the ns3-gym package so god bless you man.

@prototact
Copy link
Contributor Author

prototact commented Jul 18, 2023

Hi @prototact, could you provide a patch for the ns3gym?

I made a #88 request, I hope it is okay with you. I should specify that my patch is about supporting nested dicts and not multidimensional arrays, but a similar solution may work (recursively call _pack_data)

@Abdelkader-gnichi
Copy link

Abdelkader-gnichi commented Jul 18, 2023

@prototact thank you a lot i really appreciate your response and your work.
Can you tell me please about your project that you use ns3-gym to make it.

@prototact
Copy link
Contributor Author

I use 5g-Lena with ns3-gym to simulate 5g network slicing. However, ns3 is still lacking Edge and Core Network support, and it does not look like it will be done any time soon, so I am uncertain if I will proceed with the project.

@Abdelkader-gnichi
Copy link

Nice project and ns3 it is huge and need time and effort to work with it, my project is a self aware sdn topology that that configure ofswitch13 switches in order to make the traffic reach it's final destination through this switches based on DRL agent decisions (the decisions are the outgoing output port that will be used by the switche\s )

@Abdelkader-gnichi
Copy link

Abdelkader-gnichi commented Jul 18, 2023

@prototact I want to ask about feeding the agent with the observation, so did you use OpenGymBoxContainer or OpenGymDict
And for the actionspace what did you use cos my action space must be discrete ( i need to get 3 value from the agent and use np.argmax to take the the biggest one) so if you have some ideas i will so thankful if you share them with and thanks in advance.

@Abdelkader-gnichi
Copy link

Hi @prototact, could you provide a patch for the ns3gym?

Hi @pgawlowicz did you merge the patch of multidimensional arrays in ns3gym?

@Abdelkader-gnichi
Copy link

Hi @prototact does your patch of ns3-gym sends multiple actions to the simulation part as multi-dict space ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants