-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Avoid double loading #64
Avoid double loading #64
Conversation
please add yourself (and @psobolewskiPhD while you're at it) to the authors list as well! |
Added myself and @psobolewskiPhD to authorlist
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Makes sense to me and it works nicely locally.
Whether you click the list view or the thumbnail, there is no double loading and the selection in the two remains synced.
Co-authored-by: Peter Sobolewski <[email protected]>
I fixed the conflict--go new CI! 🚀 |
random side note: either of you should be able to push a new release to PyPI by tagging a commit on main and pushing to main. for example: git tag -a v0.2.0 -m v0.2.0
git push upstream --follow-tags |
Thanks @tlambert03 ! |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #64 +/- ##
==========================================
- Coverage 33.21% 33.13% -0.08%
==========================================
Files 13 13
Lines 843 845 +2
==========================================
Hits 280 280
- Misses 563 565 +2 ☔ View full report in Codecov by Sentry. |
For the sake of expediency, I'm going to ignore the coverage fails and just merge. |
@psobolewskiPhD I agree with the release. I guess some of the bugs that may or may not be slumbering in the code will only show up over time, anyways. |
Fixes #61. Essentially, the treeview and the thumbgrid both load an image upon clicking an item, but selecting an item in the treeview autoselects the respective item in the thumbgrid -> double selection.
This PR basically checks whether the two are in sync and triggers the loading only once.