Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid double loading #64

Merged
merged 7 commits into from
Jan 7, 2025

Conversation

jo-mueller
Copy link
Collaborator

Fixes #61. Essentially, the treeview and the thumbgrid both load an image upon clicking an item, but selecting an item in the treeview autoselects the respective item in the thumbgrid -> double selection.

This PR basically checks whether the two are in sync and triggers the loading only once.

@jo-mueller jo-mueller added the bug Something isn't working label Jan 6, 2025
@tlambert03
Copy link
Owner

please add yourself (and @psobolewskiPhD while you're at it) to the authors list as well!

Added myself and @psobolewskiPhD to authorlist
Copy link
Collaborator

@psobolewskiPhD psobolewskiPhD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense to me and it works nicely locally.
Whether you click the list view or the thumbnail, there is no double loading and the selection in the two remains synced.

Co-authored-by: Peter Sobolewski <[email protected]>
@psobolewskiPhD
Copy link
Collaborator

I fixed the conflict--go new CI! 🚀

@tlambert03
Copy link
Owner

random side note: either of you should be able to push a new release to PyPI by tagging a commit on main and pushing to main. for example:

git tag -a v0.2.0 -m v0.2.0
git push upstream --follow-tags

@psobolewskiPhD
Copy link
Collaborator

Thanks @tlambert03 !
Let's put that in the README for our future selves:
#70

Copy link

codecov bot commented Jan 7, 2025

Codecov Report

Attention: Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.

Project coverage is 33.13%. Comparing base (5ec1a5b) to head (957e775).
Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
src/napari_omero/widgets/main.py 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #64      +/-   ##
==========================================
- Coverage   33.21%   33.13%   -0.08%     
==========================================
  Files          13       13              
  Lines         843      845       +2     
==========================================
  Hits          280      280              
- Misses        563      565       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@psobolewskiPhD
Copy link
Collaborator

For the sake of expediency, I'm going to ignore the coverage fails and just merge.
@jo-mueller I think this plus the groups thing is pretty good for a release? unless we want to try to tackle some other things.
I'll let y'all do the honors.

@psobolewskiPhD psobolewskiPhD merged commit 1d53966 into tlambert03:main Jan 7, 2025
11 of 13 checks passed
@jo-mueller
Copy link
Collaborator Author

@psobolewskiPhD I agree with the release. I guess some of the bugs that may or may not be slumbering in the code will only show up over time, anyways.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Images are loaded twice
3 participants