Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] rfactor + cache_write resulting incorrect schedules and buffer shape #266

Open
vinx13 opened this issue Feb 5, 2021 · 6 comments
Open

Comments

@vinx13
Copy link
Collaborator

vinx13 commented Feb 5, 2021

Two issues I found that might be related to rfactor :
https://gist.github.com/vinx13/049c51021b701c133e8aca2664c9a55d

  • the first schedule schedule_sparse_dense_cuda_0: calling rfactor after cache_write makes the copying-back block lost
  • the second schedule schedule_sparse_dense_cuda1: the shape of BSRmm_rf_local is not inferred correctly, it doesn’t affect performance though. Read/write region looks correct

@spectrometerHBH @MasterJH5574

@junrushao
Copy link
Member

Is this bug fixed on mainline @MasterJH5574?

@MasterJH5574
Copy link
Collaborator

MasterJH5574 commented Sep 11, 2021

Is this bug fixed on mainline @MasterJH5574?

@junrushao1994 I'm not sure because I knew nothing about rfactor at that time. Will check it soon.

@MasterJH5574
Copy link
Collaborator

@junrushao1994 Bug 1 was fixed before. As for Bug 2, since cross-thread reduction hasn't been upstreamed, we may only check whether it's fixed after cross-thread reduction upstreming.

@junrushao
Copy link
Member

Sounds great! I'm going to close this issue and wait for cross-thread reduction stuff upstreamed 😄 Perhaps it is a good unittest to add

@MasterJH5574
Copy link
Collaborator

Bug 2 should be a problem of other lowering passes like CompactBufferAllocation (I guess so). Anyway, I will keep an eye on this issue when doing upstreaming.

@junrushao
Copy link
Member

junrushao commented Sep 13, 2021

Would be nice if we can fix the corresponding passes. Don’t hesitate to ask Siyuan or me if there is any question on these passes

@junrushao junrushao reopened this Sep 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants